-
-
Notifications
You must be signed in to change notification settings - Fork 570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Astro 5 + collection loaders + legacy collections support #2612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 14, 2024
This was referenced Dec 14, 2024
This was referenced Dec 16, 2024
This was referenced Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🚨 action
Changes to GitHub Action workflows
🌟 core
Changes to Starlight’s main package
📚 docs
Documentation website changes
🌟 docsearch
Changes to Starlight’s DocSearch plugin
i18n
Anything to do with internationalization & translation efforts
🌟 markdoc
Changes to Starlight’s Markdoc package
🌟 tailwind
Changes to Starlight’s Tailwind package
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a draft adding Astro 5 support to Starlight, adding collection loaders for our content collections and support for legacy collections.
The first goal was to get everything working with Astro 5. There is room for improvements and potential refactoring, but the goal was to get everything in place first to get a better overview of what needs to be done and later iterate on it.
The MDX dependency case is temporarily workaround by making it a peer dependency of Starlight and installing it manually everywhere it's needed until we have a better solution (in discussion).Note that the collection locations are not yet user-configurable.
Remaining tasks
// TODO(HiDeoo)
comments are addressed and removed@astrojs/starlight
in some packages (see changesets for the one that needs an update)code.mdx
files@lunaria-ignore:src/content/docs/**/code.mdx;src/content/docs/code.mdx;