feat(cli): support excluding projects with --project=!pattern
#6924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
sheremet-va
requested changes
Nov 18, 2024
| @@ -7,6 +7,9 @@ test.each([ | |||
| { pattern: '*j*', expected: ['project_1', 'project_2'] }, | |||
| { pattern: 'project*', expected: ['project_1', 'project_2'] }, | |||
| { pattern: 'space*', expected: ['space_1'] }, | |||
| { pattern: '!project_1', expected: ['project_2', 'space_1'] }, | |||
| { pattern: '!project*', expected: ['space_1'] }, | |||
| { pattern: '!project', expected: ['project_1', 'project_2', 'space_1'] }, | |||
| ])('should match projects correctly: $pattern', async ({ pattern, expected }) => { | |||
There was a problem hiding this comment.
Hm, this test seems a bit flawed. What about adding something like this?
expect(ctx.projects.map(p => p.name)).toEqual(expected)Note: await runVitest returns ctx
sheremet-va
reviewed
Nov 18, 2024
| root: 'fixtures/project', | ||
| reporters: ['basic'], | ||
| project: pattern, | ||
| }) | ||
|
|
||
| expect(stderr).toBeFalsy() |
There was a problem hiding this comment.
No need to remove other assertions - they assert the reporter behaviour (what users see). stderr is especially important - we should be able to see what's wrong without reruning the test
sheremet-va
approved these changes
Nov 18, 2024
|
LGTM! |
|
Awesome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR allows a leading
!to negate patterns in the--projectoption, making it possible to exclude certain projects when runningvitest.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.