-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: spy.mockReset
changes
#6426
Merged
sheremet-va
merged 9 commits into
vitest-dev:main
from
Lordfirespeed:feat/mock-reset-changes
Dec 5, 2024
Merged
feat!: spy.mockReset
changes
#6426
sheremet-va
merged 9 commits into
vitest-dev:main
from
Lordfirespeed:feat/mock-reset-changes
Dec 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lordfirespeed
changed the title
Feat!/
Feat!: Aug 29, 2024
spy.mockReset
changesspy.mockReset
changes
Lordfirespeed
changed the title
Feat!:
feat!: Aug 29, 2024
spy.mockReset
changesspy.mockReset
changes
✅ Deploy Preview for vitest-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
also improve some test names
sheremet-va
force-pushed
the
feat/mock-reset-changes
branch
from
December 5, 2024 13:47
d8f5d9d
to
c85d5d8
Compare
sheremet-va
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Warning
This is a breaking change.
See #6378, #6308
This PR changes the behaviour of
mockReset
to the proposed behaviour ofmockRevert
in #6378.That is,
spy.mockReset()
will reset the inner implementation ofspy
to its original.Previously,
spy.mockReset
would reset the inner implementation ofspy
to() => undefined
.PR Checklist
pnpm-lock.yaml
unless you introduce a new test example.Tests
pnpm test:ci
.Documentation
pnpm run docs
command.Changesets
feat:
,fix:
,perf:
,docs:
, orchore:
.