Release: Patch 8.4.6 #29679
Merged
Release: Patch 8.4.6 #29679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
added
the
release
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
LGTM
5 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
30 tasks
storybook-bot
force-pushed
the
version-patch-from-8.4.5
branch
5 times, most recently
from
773f9b8 to
151e413
Compare
storybook-bot
force-pushed
the
version-patch-from-8.4.5
branch
7 times, most recently
from
74c24bd to
4a81359
Compare
yannbf
added
freeze
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 15e14c4. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
storybook-bot
force-pushed
the
version-patch-from-8.4.5
branch
from
7def712 to
4b31c87
Compare
|
Very important patch for angular 19, we are blocked by that issue, would love to get it as soon as possible |
For sure! I'm working hard to get this in. There are unrelated changes which are blocking our CI but they will be fixed shortly! |
Angular: Default to standalone components in Angular v19 (cherry picked from commit 8ba4fb5)
Docs: Maintenance - Fix snippets and documentation (cherry picked from commit 896be2b)
Portable stories: Support multiple annotation notations from preview (cherry picked from commit 020074b)
Build: Fix portable stories tests by moving from jsdom to happy-dom (cherry picked from commit 0a656a7)
storybook-bot
force-pushed
the
version-patch-from-8.4.5
branch
from
16447d0 to
e243c64
Compare
…windows Addon Test: Use pathe for better windows support (cherry picked from commit 1bb5920)
Frameworks: Add Vite 6 support (cherry picked from commit 8e5be14)
…plugin-5 Svelte: Support `@sveltejs/vite-plugin-svelte` v5 (cherry picked from commit e870c8c)
Build: Attempt to fix Vite 6 sandboxes (cherry picked from commit a4ae081)
FrozenPandaz
pushed a commit
to nrwl/nx
that referenced
this pull request
Dec 2, 2024
## Third-party deps support for Angular v19
- [x] `jest-preset-angular`
- [x] PRs:
- [x] thymikee/jest-preset-angular#2835
- [x] Released:
- [x] RC:
https://github.com/thymikee/jest-preset-angular/releases/tag/v14.4.0-rc.0
- [x] Stable:
https://github.com/thymikee/jest-preset-angular/releases/tag/v14.4.0
- [x] Angular ESLint
- [x] PRs:
- [x] angular-eslint/angular-eslint#2109
- [x] Released:
- [x]
https://github.com/angular-eslint/angular-eslint/releases/tag/v19.0.0
- [x] Storybook
- [x] PRs:
- [x] storybookjs/storybook#29659
- [x] storybookjs/storybook#29677
- [x] Released:
- [x] storybookjs/storybook#29679
- [ ] NgRx
- [x] PRs:
- [x] ngrx/platform#4602
- [ ] Released:
- [x] Beta:
https://github.com/ngrx/platform/blob/main/CHANGELOG.md#1900-beta0-2024-11-20
- [ ] Stable:
- [ ] Analog
- [x] PRs:
- [x] analogjs/analog#1447
- [x] analogjs/analog#1451
- [ ] Released:
- [x] Beta:
https://github.com/analogjs/analog/releases/tag/v1.10.0-beta.6
- [ ] Stable:
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->
<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->
<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->
## Current Behavior
<!-- This is the behavior we have today -->
Angular v19 is not supported.
## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->
Angular v19 should be supported.
## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->
Fixes #29028
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated pull request that bumps the version from
8.4.5to8.4.6.Once this pull request is merged, it will trigger a new release of version
8.4.6.If you're not a core maintainer with permissions to release you can ignore this pull request.
To do
Before merging the PR, there are a few QA steps to go through:
And for each change below:
This is a list of all the PRs merged and commits pushed directly to
next, that will be part of this release:@sveltejs/vite-plugin-sveltev5 #29731🍒 Manual cherry picking needed!
The following pull requests could not be cherry-picked automatically because it resulted in merge conflicts.
For each pull request below, you need to either manually cherry pick it, or discard it by replacing the "patch:yes" label with "patch:no" on the PR and re-generate this PR.
git cherry-pick -m1 -x 1bb5920115f5a4978bbe58bd51a10e1591cf5c06git cherry-pick -m1 -x 8e5be14c49a2b42ee473b79cfd6b78858ca2e172git cherry-pick -m1 -x e870c8c7a390520aba5d27bce7dcf3551a53bf49git cherry-pick -m1 -x a4ae081b261f9d1f274185a9478bc48f930ea668If you've made any changes doing the above QA (change PR titles, revert PRs), manually trigger a re-generation of this PR with this workflow and wait for it to finish. It will wipe your progress in this to do, which is expected.
Feel free to manually commit any changes necessary to this branch after you've done the last re-generation, following the Make Manual Changes section in the docs, especially if you're making changes to the changelog.
When everything above is done:
Generated changelog
8.4.6
@sveltejs/vite-plugin-sveltev5 - #29731, thanks @JReinhold!