Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular: Support v19 #29659

Merged
merged 4 commits into from
Nov 20, 2024
Merged

Conversation

leosvelperez
Copy link
Contributor

@leosvelperez leosvelperez commented Nov 19, 2024

Closes #

What I did

I have widened the version range of Angular peer dependencies to allow the usage of Angular v19. Additionally, I updated some component and pipe metadata with standalone: false where needed. Angular v19 switches the default for standalone to true.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This pull request has been released as version 0.0.0-pr-29659-sha-1f47b682. Try it out in a new sandbox by running npx storybook@0.0.0-pr-29659-sha-1f47b682 sandbox or in an existing project with npx storybook@0.0.0-pr-29659-sha-1f47b682 upgrade.

More information
Published version 0.0.0-pr-29659-sha-1f47b682
Triggered by @yannbf
Repository leosvelperez/storybook
Branch feat/angular-19
Commit 1f47b682
Datetime Wed Nov 20 06:17:08 UTC 2024 (1732083428)
Workflow run 11927838404

To request a new release of this pull request, mention the @storybookjs/core team.

core team members can create a new canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=29659

name before after diff z %
createSize 0 B 0 B 0 B - -
generateSize 78.4 MB 78.4 MB 0 B 0.28 0%
initSize 144 MB 144 MB 266 B 1.53 0%
diffSize 65.3 MB 65.3 MB 266 B 4.36 0%
buildSize 7.03 MB 7.03 MB 0 B 4.35 0%
buildSbAddonsSize 1.51 MB 1.51 MB 0 B - 0%
buildSbCommonSize 195 kB 195 kB 0 B - 0%
buildSbManagerSize 2.06 MB 2.06 MB 0 B 4.36 0%
buildSbPreviewSize 271 kB 271 kB 0 B - 0%
buildStaticSize 0 B 0 B 0 B - -
buildPrebuildSize 4.04 MB 4.04 MB 0 B 4.36 0%
buildPreviewSize 3 MB 3 MB 0 B 0.99 0%
testBuildSize 0 B 0 B 0 B - -
testBuildSbAddonsSize 0 B 0 B 0 B - -
testBuildSbCommonSize 0 B 0 B 0 B - -
testBuildSbManagerSize 0 B 0 B 0 B - -
testBuildSbPreviewSize 0 B 0 B 0 B - -
testBuildStaticSize 0 B 0 B 0 B - -
testBuildPrebuildSize 0 B 0 B 0 B - -
testBuildPreviewSize 0 B 0 B 0 B - -
name before after diff z %
createTime 25.8s 7.5s -18s -259ms -1.26 🔰-240.3%
generateTime 22.9s 21s -1s -805ms -0.08 -8.6%
initTime 14.9s 15.7s 814ms 0.58 5.2%
buildTime 8s 8.8s 842ms -0.09 9.5%
testBuildTime 0ms 0ms 0ms - -
devPreviewResponsive 6.8s 7.8s 999ms 3.75 🔺12.7%
devManagerResponsive 4s 4.5s 437ms 2.67 🔺9.6%
devManagerHeaderVisible 608ms 845ms 237ms 4.16 🔺28%
devManagerIndexVisible 702ms 941ms 239ms 3.57 🔺25.4%
devStoryVisibleUncached 1.1s 1s -124ms 0.4 -11.8%
devStoryVisible 647ms 933ms 286ms 3.81 🔺30.7%
devAutodocsVisible 502ms 978ms 476ms 9.03 🔺48.7%
devMDXVisible 548ms 744ms 196ms 4.58 🔺26.3%
buildManagerHeaderVisible 611ms 803ms 192ms 3.63 🔺23.9%
buildManagerIndexVisible 628ms 1.1s 508ms 7.9 🔺44.7%
buildStoryVisible 613ms 794ms 181ms 3.55 🔺22.8%
buildAutodocsVisible 601ms 773ms 172ms 4.8 🔺22.3%
buildMDXVisible 493ms 700ms 207ms 5.07 🔺29.6%

Greptile Summary

Updates Angular support to v19 by modifying peer dependency ranges and adding explicit standalone component settings to maintain compatibility with Angular's new defaults.

  • Updated peer dependencies in code/frameworks/angular/package.json to support Angular versions up to v20.0.0
  • Added standalone: false to components and pipes in template stories to maintain compatibility with Angular v19's new defaults
  • Removed test exclusion tags and Chromatic disable parameters from story configurations
  • Updated devDependencies to Angular v17.3.0 for proper testing

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

10 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile

"@angular/forms": ">=15.0.0 < 19.0.0",
"@angular/platform-browser": ">=15.0.0 < 19.0.0",
"@angular/platform-browser-dynamic": ">=15.0.0 < 19.0.0",
"@angular-devkit/architect": ">=0.1500.0 < 0.2000.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Version range for architect package is inconsistent with others - using 0.2000.0 vs 20.0.0 pattern

Copy link

nx-cloud bot commented Nov 19, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 1f47b68. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@yannbf yannbf added feature request angular ci:merged Run the CI jobs that normally run when merged. labels Nov 19, 2024
@storybook-bot
Copy link
Contributor

Failed to publish canary version of this pull request, triggered by @yannbf. See the failed workflow run at: https://github.com/storybookjs/storybook/actions/runs/11917894925

@storybook-pr-benchmarking
Copy link

storybook-pr-benchmarking bot commented Nov 19, 2024

Package Benchmarks

Commit: 1f47b68, ran on 19 November 2024 at 18:31:37 UTC

The following packages have significant changes to their size or dependencies:

@storybook/angular

Before After Difference
Dependency count 257 258 🚨 +1 🚨
Self size 362 KB 362 KB 0 B
Dependency size 34.20 MB 34.49 MB 🚨 +291 KB 🚨
Bundle Size Analyzer Link Link

@storybook/experimental-nextjs-vite

Before After Difference
Dependency count 87 87 0
Self size 230 KB 230 KB 0 B
Dependency size 31.03 MB 31.30 MB 🚨 +270 KB 🚨
Bundle Size Analyzer Link Link

@valentinpalkovic
Copy link
Contributor

LGTM! Thank you so much for the update and maintenance.

@valentinpalkovic valentinpalkovic merged commit fa3cf88 into storybookjs:next Nov 20, 2024
67 of 69 checks passed
@github-actions github-actions bot mentioned this pull request Nov 20, 2024
6 tasks
@leosvelperez leosvelperez deleted the feat/angular-19 branch November 20, 2024 10:25
@yannbf yannbf added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Nov 20, 2024
@github-actions github-actions bot mentioned this pull request Nov 20, 2024
11 tasks
yannbf pushed a commit that referenced this pull request Nov 20, 2024
Angular: Support v19
(cherry picked from commit fa3cf88)
@github-actions github-actions bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label Nov 20, 2024
FrozenPandaz pushed a commit to nrwl/nx that referenced this pull request Dec 2, 2024
## Third-party deps support for Angular v19

- [x] `jest-preset-angular`
  - [x] PRs:
    - [x] thymikee/jest-preset-angular#2835
  - [x] Released:
- [x] RC:
https://github.com/thymikee/jest-preset-angular/releases/tag/v14.4.0-rc.0
- [x] Stable:
https://github.com/thymikee/jest-preset-angular/releases/tag/v14.4.0
- [x] Angular ESLint
  - [x] PRs:
    - [x] angular-eslint/angular-eslint#2109
  - [x] Released:
- [x]
https://github.com/angular-eslint/angular-eslint/releases/tag/v19.0.0
- [x] Storybook
  - [x] PRs:
    - [x] storybookjs/storybook#29659
    - [x] storybookjs/storybook#29677
  - [x] Released:
    - [x] storybookjs/storybook#29679
- [ ] NgRx
  - [x] PRs:
    - [x] ngrx/platform#4602
  - [ ] Released:
- [x] Beta:
https://github.com/ngrx/platform/blob/main/CHANGELOG.md#1900-beta0-2024-11-20
    - [ ] Stable:
- [ ] Analog
  - [x] PRs:
    - [x] analogjs/analog#1447
    - [x] analogjs/analog#1451
  - [ ] Released:
- [x] Beta:
https://github.com/analogjs/analog/releases/tag/v1.10.0-beta.6
    - [ ] Stable:

<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
<!-- This is the behavior we have today -->

Angular v19 is not supported.

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

Angular v19 should be supported.

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->
 
Fixes #29028
@yannbf yannbf self-assigned this Dec 17, 2024
@yannbf yannbf added needs qa Indicates that this needs manual QA during the upcoming minor/major release and removed needs qa Indicates that this needs manual QA during the upcoming minor/major release labels Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
angular ci:merged Run the CI jobs that normally run when merged. feature request patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants