-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Angular: Support v19 #29659
Angular: Support v19 #29659
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
10 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
"@angular/forms": ">=15.0.0 < 19.0.0", | ||
"@angular/platform-browser": ">=15.0.0 < 19.0.0", | ||
"@angular/platform-browser-dynamic": ">=15.0.0 < 19.0.0", | ||
"@angular-devkit/architect": ">=0.1500.0 < 0.2000.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: Version range for architect package is inconsistent with others - using 0.2000.0 vs 20.0.0 pattern
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 1f47b68. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
Failed to publish canary version of this pull request, triggered by @yannbf. See the failed workflow run at: https://github.com/storybookjs/storybook/actions/runs/11917894925 |
Package BenchmarksCommit: The following packages have significant changes to their size or dependencies:
|
Before | After | Difference | |
---|---|---|---|
Dependency count | 257 | 258 | 🚨 +1 🚨 |
Self size | 362 KB | 362 KB | 0 B |
Dependency size | 34.20 MB | 34.49 MB | 🚨 +291 KB 🚨 |
Bundle Size Analyzer | Link | Link |
@storybook/experimental-nextjs-vite
Before | After | Difference | |
---|---|---|---|
Dependency count | 87 | 87 | 0 |
Self size | 230 KB | 230 KB | 0 B |
Dependency size | 31.03 MB | 31.30 MB | 🚨 +270 KB 🚨 |
Bundle Size Analyzer | Link | Link |
LGTM! Thank you so much for the update and maintenance. |
Angular: Support v19 (cherry picked from commit fa3cf88)
## Third-party deps support for Angular v19 - [x] `jest-preset-angular` - [x] PRs: - [x] thymikee/jest-preset-angular#2835 - [x] Released: - [x] RC: https://github.com/thymikee/jest-preset-angular/releases/tag/v14.4.0-rc.0 - [x] Stable: https://github.com/thymikee/jest-preset-angular/releases/tag/v14.4.0 - [x] Angular ESLint - [x] PRs: - [x] angular-eslint/angular-eslint#2109 - [x] Released: - [x] https://github.com/angular-eslint/angular-eslint/releases/tag/v19.0.0 - [x] Storybook - [x] PRs: - [x] storybookjs/storybook#29659 - [x] storybookjs/storybook#29677 - [x] Released: - [x] storybookjs/storybook#29679 - [ ] NgRx - [x] PRs: - [x] ngrx/platform#4602 - [ ] Released: - [x] Beta: https://github.com/ngrx/platform/blob/main/CHANGELOG.md#1900-beta0-2024-11-20 - [ ] Stable: - [ ] Analog - [x] PRs: - [x] analogjs/analog#1447 - [x] analogjs/analog#1451 - [ ] Released: - [x] Beta: https://github.com/analogjs/analog/releases/tag/v1.10.0-beta.6 - [ ] Stable: <!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> Angular v19 is not supported. ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> Angular v19 should be supported. ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #29028
Closes #
What I did
I have widened the version range of Angular peer dependencies to allow the usage of Angular v19. Additionally, I updated some component and pipe metadata with
standalone: false
where needed. Angular v19 switches the default forstandalone
totrue
.Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.ts
Make sure this PR contains one of the labels below:
Available labels
bug
: Internal changes that fixes incorrect behavior.maintenance
: User-facing maintenance tasks.dependencies
: Upgrading (sometimes downgrading) dependencies.build
: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup
: Minor cleanup style change. Will not show up in release changelog.documentation
: Documentation only changes. Will not show up in release changelog.feature request
: Introducing a new feature.BREAKING CHANGE
: Changes that break compatibility in some way with current major version.other
: Changes that don't fit in the above categories.🦋 Canary release
This pull request has been released as version
0.0.0-pr-29659-sha-1f47b682
. Try it out in a new sandbox by runningnpx storybook@0.0.0-pr-29659-sha-1f47b682 sandbox
or in an existing project withnpx storybook@0.0.0-pr-29659-sha-1f47b682 upgrade
.More information
0.0.0-pr-29659-sha-1f47b682
feat/angular-19
1f47b682
1732083428
)To request a new release of this pull request, mention the
@storybookjs/core
team.core team members can create a new canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=29659
Greptile Summary
Updates Angular support to v19 by modifying peer dependency ranges and adding explicit standalone component settings to maintain compatibility with Angular's new defaults.
code/frameworks/angular/package.json
to support Angular versions up to v20.0.0standalone: false
to components and pipes in template stories to maintain compatibility with Angular v19's new defaults