Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for Angular 19 #2835

Merged
merged 5 commits into from
Nov 21, 2024
Merged

feat: add support for Angular 19 #2835

merged 5 commits into from
Nov 21, 2024

Conversation

leosvelperez
Copy link
Contributor

@leosvelperez leosvelperez commented Nov 18, 2024 •
edited
Loading

Summary

Angular 19 was just released.

This PR contains the following changes:

  • Bumps the Angular packages' versions to the latest pre-release version available
  • Add a new test application for Angular v19

Test plan

  • Updated the "monorepo" and "yarn workspace" example apps to v19
  • Added a new test application for v19

Additionally, we've been testing jest-preset-angular + Angular 19 as part of the Angular 19 support for Nx, and everything works other than a peer dependency error.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@leosvelperez leosvelperez force-pushed the feat/angular-19 branch 3 times, most recently from 3d19822 to 6bc9d23 Compare November 19, 2024 13:20
@leosvelperez
Copy link
Contributor Author

leosvelperez commented Nov 19, 2024 •
edited
Loading

@ahnpnl It seems that the minified jit_transform bundle has an issue. If I don't minify it, all the tests pass successfully. Could you please assist with that?

@leosvelperez leosvelperez force-pushed the feat/angular-19 branch 2 times, most recently from 94c551e to 6ed4369 Compare November 20, 2024 09:43
@leosvelperez
Copy link
Contributor Author

leosvelperez commented Nov 20, 2024 •
edited
Loading

@ahnpnl It seems that the minified jit_transform bundle has an issue. If I don't minify it, all the tests pass successfully. Could you please assist with that?

So, a couple of other things work:

  • Disabling syntax minification by running esbuild with --minify-whitespace --minify-identifiers instead of just --minify. This excludes --minify-syntax (https://esbuild.github.io/api/#minify). This results in a 612.6kb bundle.
  • Keep --minify but set an older target like --target=es6. This results in a 596.6kb bundle.

With full minification and using modern JS features (the current setup that doesn't work in this branch) the bundle size is 582.1kb.

@ahnpnl
Copy link
Collaborator

ahnpnl commented Nov 20, 2024 •
edited
Loading

  • Keep --minify but set an older target like --target=es6. This results in a 596.6kb bundle.

This looks good enough, the increasing amount is not too much and it's minimal change.

ahnpnl
ahnpnl approved these changes Nov 21, 2024
View reviewed changes
Copy link
Collaborator

@ahnpnl ahnpnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ahnpnl ahnpnl merged commit 4a73245 into thymikee:main Nov 21, 2024
9 checks passed
@leosvelperez leosvelperez deleted the feat/angular-19 branch November 21, 2024 08:29
@leosvelperez leosvelperez mentioned this pull request Nov 21, 2024
Merged
30 tasks
@ahnpnl ahnpnl mentioned this pull request Nov 22, 2024
Closed
1 task
@sam0r040 sam0r040 mentioned this pull request Nov 22, 2024
Closed
FrozenPandaz pushed a commit to nrwl/nx that referenced this pull request Dec 2, 2024
@leosvelperez
feat(angular): add support for angular v19 (#28847)
3ec5390 
## Third-party deps support for Angular v19

- [x] `jest-preset-angular`
  - [x] PRs:
    - [x] thymikee/jest-preset-angular#2835
  - [x] Released:
- [x] RC:
https://github.com/thymikee/jest-preset-angular/releases/tag/v14.4.0-rc.0
- [x] Stable:
https://github.com/thymikee/jest-preset-angular/releases/tag/v14.4.0
- [x] Angular ESLint
  - [x] PRs:
    - [x] angular-eslint/angular-eslint#2109
  - [x] Released:
- [x]
https://github.com/angular-eslint/angular-eslint/releases/tag/v19.0.0
- [x] Storybook
  - [x] PRs:
    - [x] storybookjs/storybook#29659
    - [x] storybookjs/storybook#29677
  - [x] Released:
    - [x] storybookjs/storybook#29679
- [ ] NgRx
  - [x] PRs:
    - [x] ngrx/platform#4602
  - [ ] Released:
- [x] Beta:
https://github.com/ngrx/platform/blob/main/CHANGELOG.md#1900-beta0-2024-11-20
    - [ ] Stable:
- [ ] Analog
  - [x] PRs:
    - [x] analogjs/analog#1447
    - [x] analogjs/analog#1451
  - [ ] Released:
- [x] Beta:
https://github.com/analogjs/analog/releases/tag/v1.10.0-beta.6
    - [ ] Stable:

<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
<!-- This is the behavior we have today -->

Angular v19 is not supported.

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

Angular v19 should be supported.

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->
 
Fixes #29028
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahnpnl ahnpnl ahnpnl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leosvelperez @ahnpnl