-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Frameworks: Add Vite 6 support #29710
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 27a47e8. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
7 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
Package BenchmarksCommit: The following packages have significant changes to their size or dependencies:
|
Before | After | Difference | |
---|---|---|---|
Dependency count | 7 | 7 | 0 |
Self size | 1.89 MB | 1.89 MB | 0 B |
Dependency size | 10.12 MB | 10.27 MB | 🚨 +142 KB 🚨 |
Bundle Size Analyzer | Link | Link |
@storybook/builder-webpack5
Before | After | Difference | |
---|---|---|---|
Dependency count | 223 | 223 | 0 |
Self size | 79 KB | 79 KB | 0 B |
Dependency size | 29.56 MB | 29.60 MB | 🚨 +42 KB 🚨 |
Bundle Size Analyzer | Link | Link |
@storybook/angular
Before | After | Difference | |
---|---|---|---|
Dependency count | 258 | 258 | 0 |
Self size | 362 KB | 362 KB | 0 B |
Dependency size | 34.49 MB | 34.54 MB | 🚨 +42 KB 🚨 |
Bundle Size Analyzer | Link | Link |
@storybook/ember
Before | After | Difference | |
---|---|---|---|
Dependency count | 250 | 250 | 0 |
Self size | 22 KB | 22 KB | 0 B |
Dependency size | 31.96 MB | 32.00 MB | 🚨 +42 KB 🚨 |
Bundle Size Analyzer | Link | Link |
@storybook/html-webpack5
Before | After | Difference | |
---|---|---|---|
Dependency count | 233 | 233 | 0 |
Self size | 6 KB | 6 KB | 0 B |
Dependency size | 30.10 MB | 30.15 MB | 🚨 +42 KB 🚨 |
Bundle Size Analyzer | Link | Link |
@storybook/nextjs
Before | After | Difference | |
---|---|---|---|
Dependency count | 587 | 587 | 0 |
Self size | 464 KB | 464 KB | 0 B |
Dependency size | 83.77 MB | 83.81 MB | 🚨 +42 KB 🚨 |
Bundle Size Analyzer | Link | Link |
@storybook/preact-webpack5
Before | After | Difference | |
---|---|---|---|
Dependency count | 231 | 231 | 0 |
Self size | 6 KB | 6 KB | 0 B |
Dependency size | 29.68 MB | 29.72 MB | 🚨 +42 KB 🚨 |
Bundle Size Analyzer | Link | Link |
@storybook/react-webpack5
Before | After | Difference | |
---|---|---|---|
Dependency count | 309 | 309 | 0 |
Self size | 6 KB | 6 KB | 0 B |
Dependency size | 40.84 MB | 40.88 MB | 🚨 +42 KB 🚨 |
Bundle Size Analyzer | Link | Link |
@storybook/server-webpack5
Before | After | Difference | |
---|---|---|---|
Dependency count | 241 | 241 | 0 |
Self size | 14 KB | 14 KB | 0 B |
Dependency size | 31.08 MB | 31.12 MB | 🚨 +42 KB 🚨 |
Bundle Size Analyzer | Link | Link |
@storybook/svelte-webpack5
Before | After | Difference | |
---|---|---|---|
Dependency count | 296 | 296 | 0 |
Self size | 6 KB | 6 KB | 0 B |
Dependency size | 37.67 MB | 37.71 MB | 🚨 +42 KB 🚨 |
Bundle Size Analyzer | Link | Link |
@storybook/vue3-vite
Before | After | Difference | |
---|---|---|---|
Dependency count | 107 | 107 | 0 |
Self size | 15 KB | 15 KB | 🚨 +10 B 🚨 |
Dependency size | 42.52 MB | 42.55 MB | 🚨 +33 KB 🚨 |
Bundle Size Analyzer | Link | Link |
@storybook/vue3-webpack5
Before | After | Difference | |
---|---|---|---|
Dependency count | 483 | 483 | 0 |
Self size | 6 KB | 6 KB | 0 B |
Dependency size | 54.08 MB | 54.12 MB | 🚨 +42 KB 🚨 |
Bundle Size Analyzer | Link | Link |
@storybook/web-components-webpack5
Before | After | Difference | |
---|---|---|---|
Dependency count | 231 | 231 | 0 |
Self size | 5 KB | 5 KB | 0 B |
Dependency size | 29.73 MB | 29.77 MB | 🚨 +42 KB 🚨 |
Bundle Size Analyzer | Link | Link |
@storybook/cli
Before | After | Difference | |
---|---|---|---|
Dependency count | 390 | 390 | 0 |
Self size | 484 KB | 484 KB | 0 B |
Dependency size | 74.48 MB | 74.63 MB | 🚨 +151 KB 🚨 |
Bundle Size Analyzer | Link | Link |
@storybook/codemod
Before | After | Difference | |
---|---|---|---|
Dependency count | 270 | 270 | 0 |
Self size | 612 KB | 612 KB | 0 B |
Dependency size | 64.48 MB | 64.63 MB | 🚨 +151 KB 🚨 |
Bundle Size Analyzer | Link | Link |
create-storybook
Before | After | Difference | |
---|---|---|---|
Dependency count | 105 | 105 | 0 |
Self size | 1.11 MB | 1.11 MB | 0 B |
Dependency size | 42.34 MB | 42.48 MB | 🚨 +142 KB 🚨 |
Bundle Size Analyzer | Link | Link |
@storybook/source-loader
Before | After | Difference | |
---|---|---|---|
Dependency count | 5 | 5 | 0 |
Self size | 41 KB | 41 KB | 0 B |
Dependency size | 10.07 MB | 10.21 MB | 🚨 +142 KB 🚨 |
Bundle Size Analyzer | Link | Link |
@storybook/preset-vue3-webpack
Before | After | Difference | |
---|---|---|---|
Dependency count | 366 | 366 | 0 |
Self size | 9 KB | 9 KB | 0 B |
Dependency size | 45.00 MB | 45.04 MB | 🚨 +42 KB 🚨 |
Bundle Size Analyzer | Link | Link |
8de865a
to
0e0836a
Compare
0e0836a
to
27a47e8
Compare
Frameworks: Add Vite 6 support (cherry picked from commit 8e5be14)
Frameworks: Add Vite 6 support (cherry picked from commit 8e5be14)
Frameworks: Add Vite 6 support (cherry picked from commit 8e5be14)
Closes #
What I did
This PR increases the version range so projects can use Vite 6
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.ts
Make sure this PR contains one of the labels below:
Available labels
bug
: Internal changes that fixes incorrect behavior.maintenance
: User-facing maintenance tasks.dependencies
: Upgrading (sometimes downgrading) dependencies.build
: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup
: Minor cleanup style change. Will not show up in release changelog.documentation
: Documentation only changes. Will not show up in release changelog.feature request
: Introducing a new feature.BREAKING CHANGE
: Changes that break compatibility in some way with current major version.other
: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/core
team here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>
Greptile Summary
Updates Vite peer dependency ranges across multiple Storybook framework packages to add support for Vite 6 while maintaining compatibility with versions 4 and 5.
@storybook/builder-vite
peerDependencies to support Vite^4.0.0 || ^5.0.0 || ^6.0.0