Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon Test: Use pathe for better windows support #29676

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Nov 20, 2024

Closes #29570

What I did

I replaced the usage of node:path with pathe for proper Windows support.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

name before after diff z %
createSize 0 B 0 B 0 B - -
generateSize 78.4 MB 78.4 MB 4.11 kB -0.16 0%
initSize 144 MB 144 MB 4.11 kB -0.58 0%
diffSize 65.1 MB 65.1 MB 0 B -0.83 0%
buildSize 6.83 MB 6.83 MB 0 B -1.05 0%
buildSbAddonsSize 1.51 MB 1.51 MB 0 B - 0%
buildSbCommonSize 195 kB 195 kB 0 B - 0%
buildSbManagerSize 1.86 MB 1.86 MB 0 B -1.09 0%
buildSbPreviewSize 271 kB 271 kB 0 B - 0%
buildStaticSize 0 B 0 B 0 B - -
buildPrebuildSize 3.83 MB 3.83 MB 0 B -1.09 0%
buildPreviewSize 3 MB 3 MB 0 B 0.95 0%
testBuildSize 0 B 0 B 0 B - -
testBuildSbAddonsSize 0 B 0 B 0 B - -
testBuildSbCommonSize 0 B 0 B 0 B - -
testBuildSbManagerSize 0 B 0 B 0 B - -
testBuildSbPreviewSize 0 B 0 B 0 B - -
testBuildStaticSize 0 B 0 B 0 B - -
testBuildPrebuildSize 0 B 0 B 0 B - -
testBuildPreviewSize 0 B 0 B 0 B - -
name before after diff z %
createTime 15.5s 8.4s -7s -27ms -1.41 🔰-82.9%
generateTime 19.4s 25.4s 5.9s 1.18 23.4%
initTime 13.3s 14.8s 1.4s -0.02 9.5%
buildTime 7.7s 7.9s 218ms -0.94 2.7%
testBuildTime 0ms 0ms 0ms - -
devPreviewResponsive 5.8s 6.8s 963ms 1.71 🔺14.1%
devManagerResponsive 3.5s 4.1s 613ms 1.83 🔺14.7%
devManagerHeaderVisible 587ms 867ms 280ms 4.55 🔺32.3%
devManagerIndexVisible 668ms 968ms 300ms 4.06 🔺31%
devStoryVisibleUncached 1.2s 1.4s 244ms 2.34 🔺16.4%
devStoryVisible 624ms 959ms 335ms 4.32 🔺34.9%
devAutodocsVisible 542ms 738ms 196ms 4.71 🔺26.6%
devMDXVisible 701ms 831ms 130ms 4.37 🔺15.6%
buildManagerHeaderVisible 584ms 737ms 153ms 2.9 🔺20.8%
buildManagerIndexVisible 603ms 752ms 149ms 2.72 🔺19.8%
buildStoryVisible 583ms 736ms 153ms 2.85 🔺20.8%
buildAutodocsVisible 479ms 579ms 100ms 1.84 🔺17.3%
buildMDXVisible 478ms 605ms 127ms 3.11 🔺21%

@yannbf yannbf added bug patch:yes Bugfix & documentation PR that need to be picked to main branch ci:normal addon: test labels Nov 20, 2024
@storybook-bot
Copy link
Contributor

Failed to publish canary version of this pull request, triggered by @yannbf. See the failed workflow run at: https://github.com/storybookjs/storybook/actions/runs/11938646828

Copy link

nx-cloud bot commented Nov 20, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 13e54a0. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@yannbf yannbf force-pushed the yann/fix-addon-test-setup-windows branch from 567ec2e to 13e54a0 Compare November 21, 2024 08:50
@storybook-pr-benchmarking
Copy link

Package Benchmarks

Commit: 13e54a0, ran on 21 November 2024 at 09:00:28 UTC

The following packages have significant changes to their size or dependencies:

@storybook/experimental-addon-test

Before After Difference
Dependency count 61 61 0
Self size 587 KB 605 KB 🚨 +17 KB 🚨
Dependency size 13.86 MB 13.86 MB 0 B
Bundle Size Analyzer Link Link

@storybook-bot
Copy link
Contributor

Failed to publish canary version of this pull request, triggered by @yannbf. See the failed workflow run at: https://github.com/storybookjs/storybook/actions/runs/11952594770

@yannbf yannbf merged commit 1bb5920 into next Nov 21, 2024
60 checks passed
@yannbf yannbf deleted the yann/fix-addon-test-setup-windows branch November 21, 2024 13:35
yannbf added a commit that referenced this pull request Nov 28, 2024
…windows

Addon Test: Use pathe for better windows support

(cherry picked from commit 1bb5920)
yannbf added a commit that referenced this pull request Nov 29, 2024
…windows

Addon Test: Use pathe for better windows support

(cherry picked from commit 1bb5920)
yannbf added a commit that referenced this pull request Nov 29, 2024
…windows

Addon Test: Use pathe for better windows support

(cherry picked from commit 1bb5920)
@github-actions github-actions bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label Nov 29, 2024
@yannbf yannbf self-assigned this Dec 17, 2024
@yannbf yannbf added the needs qa Indicates that this needs manual QA during the upcoming minor/major release label Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addon: test bug ci:normal needs qa Indicates that this needs manual QA during the upcoming minor/major release patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Issues With Vitest Default Config
2 participants