Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React: Upgrade react-docgen-typescript to support Vite 6 #29724

Merged
merged 2 commits into from
Nov 28, 2024

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Nov 27, 2024

Closes #

What I did

This will only pass once joshwooding/vite-plugin-react-docgen-typescript#40 is released

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

name before after diff z %
createSize 0 B 0 B 0 B - -
generateSize 77.7 MB 77.7 MB 17.2 kB -0.77 0%
initSize 143 MB 130 MB -12.8 MB -37.86 🔰-9.8%
diffSize 65.2 MB 52.4 MB -12.8 MB -582.97 🔰-24.4%
buildSize 6.83 MB 6.83 MB 953 B 2.72 0%
buildSbAddonsSize 1.51 MB 1.51 MB 0 B 1.02 0%
buildSbCommonSize 195 kB 195 kB 0 B - 0%
buildSbManagerSize 1.86 MB 1.86 MB 0 B 1.3 0%
buildSbPreviewSize 271 kB 271 kB 0 B 0.9 0%
buildStaticSize 0 B 0 B 0 B - -
buildPrebuildSize 3.84 MB 3.84 MB 0 B 1.24 0%
buildPreviewSize 3 MB 3 MB 953 B 27.33 0%
testBuildSize 0 B 0 B 0 B - -
testBuildSbAddonsSize 0 B 0 B 0 B - -
testBuildSbCommonSize 0 B 0 B 0 B - -
testBuildSbManagerSize 0 B 0 B 0 B - -
testBuildSbPreviewSize 0 B 0 B 0 B - -
testBuildStaticSize 0 B 0 B 0 B - -
testBuildPrebuildSize 0 B 0 B 0 B - -
testBuildPreviewSize 0 B 0 B 0 B - -
name before after diff z %
createTime 18.3s 11.9s -6s -489ms -0.58 -54.5%
generateTime 24s 24s -60ms 0.49 -0.2%
initTime 15.1s 16.2s 1.1s 0.21 6.8%
buildTime 11.2s 8.3s -2s -910ms -0.52 -34.8%
testBuildTime 0ms 0ms 0ms - -
devPreviewResponsive 6.1s 5.2s -897ms -0.67 -17.2%
devManagerResponsive 3.6s 3.9s 214ms 0.28 5.5%
devManagerHeaderVisible 634ms 643ms 9ms 0.12 1.4%
devManagerIndexVisible 657ms 713ms 56ms 0.17 7.9%
devStoryVisibleUncached 1s 1.9s 952ms 1.29 🔺48.8%
devStoryVisible 655ms 711ms 56ms 0.21 7.9%
devAutodocsVisible 510ms 525ms 15ms -0.07 2.9%
devMDXVisible 591ms 569ms -22ms -0.02 -3.9%
buildManagerHeaderVisible 511ms 539ms 28ms -0.36 5.2%
buildManagerIndexVisible 523ms 562ms 39ms -0.34 6.9%
buildStoryVisible 513ms 540ms 27ms -0.35 5%
buildAutodocsVisible 450ms 596ms 146ms 0.59 24.5%
buildMDXVisible 446ms 457ms 11ms -0.3 2.4%

@yannbf yannbf added build Internal-facing build tooling & test updates ci:daily Run the CI jobs that normally run in the daily job. labels Nov 27, 2024
@yannbf yannbf self-assigned this Nov 27, 2024
Copy link

nx-cloud bot commented Nov 27, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 78bdb52. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@yannbf yannbf force-pushed the yann/fix-vite-6-sandboxes branch 2 times, most recently from c424e16 to b41ca9a Compare November 27, 2024 17:11
@storybook-pr-benchmarking
Copy link

storybook-pr-benchmarking bot commented Nov 27, 2024

Package Benchmarks

Commit: 78bdb52, ran on 28 November 2024 at 15:24:11 UTC

The following packages have significant changes to their size or dependencies:

@storybook/react-native-web-vite

Before After Difference
Dependency count 109 93 🎉 -16 🎉
Self size 41 KB 41 KB 0 B
Dependency size 18.70 MB 16.16 MB 🎉 -2.54 MB 🎉
Bundle Size Analyzer Link Link

@storybook/react-vite

Before After Difference
Dependency count 103 87 🎉 -16 🎉
Self size 12 KB 12 KB 0 B
Dependency size 18.56 MB 16.01 MB 🎉 -2.54 MB 🎉
Bundle Size Analyzer Link Link

@yannbf yannbf force-pushed the yann/fix-vite-6-sandboxes branch from ede1572 to 78bdb52 Compare November 28, 2024 15:13
@yannbf yannbf changed the title Build: Attempt to fix Vite 6 sandboxes React: Upgrade react-docgen-typescript to support Vite 6 Nov 28, 2024
@ndelangen ndelangen merged commit a4ae081 into next Nov 28, 2024
112 of 113 checks passed
@yannbf yannbf added bug and removed build Internal-facing build tooling & test updates labels Nov 28, 2024
@ndelangen ndelangen deleted the yann/fix-vite-6-sandboxes branch November 28, 2024 16:23
@yannbf yannbf added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Nov 29, 2024
@github-actions github-actions bot mentioned this pull request Nov 29, 2024
14 tasks
yannbf pushed a commit that referenced this pull request Nov 29, 2024
Build: Attempt to fix Vite 6 sandboxes
(cherry picked from commit a4ae081)
yannbf pushed a commit that referenced this pull request Nov 29, 2024
Build: Attempt to fix Vite 6 sandboxes
(cherry picked from commit a4ae081)
@github-actions github-actions bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ci:daily Run the CI jobs that normally run in the daily job. patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants