-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React: Upgrade react-docgen-typescript to support Vite 6 #29724
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yannbf
added
build
Internal-facing build tooling & test updates
ci:daily
Run the CI jobs that normally run in the daily job.
labels
Nov 27, 2024
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 78bdb52. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
yannbf
force-pushed
the
yann/fix-vite-6-sandboxes
branch
2 times, most recently
from
November 27, 2024 17:11
c424e16
to
b41ca9a
Compare
Package BenchmarksCommit: The following packages have significant changes to their size or dependencies:
|
Before | After | Difference | |
---|---|---|---|
Dependency count | 109 | 93 | 🎉 -16 🎉 |
Self size | 41 KB | 41 KB | 0 B |
Dependency size | 18.70 MB | 16.16 MB | 🎉 -2.54 MB 🎉 |
Bundle Size Analyzer | Link | Link |
@storybook/react-vite
Before | After | Difference | |
---|---|---|---|
Dependency count | 103 | 87 | 🎉 -16 🎉 |
Self size | 12 KB | 12 KB | 0 B |
Dependency size | 18.56 MB | 16.01 MB | 🎉 -2.54 MB 🎉 |
Bundle Size Analyzer | Link | Link |
yannbf
force-pushed
the
yann/fix-vite-6-sandboxes
branch
from
November 28, 2024 15:13
ede1572
to
78bdb52
Compare
ndelangen
approved these changes
Nov 28, 2024
yannbf
changed the title
Build: Attempt to fix Vite 6 sandboxes
React: Upgrade react-docgen-typescript to support Vite 6
Nov 28, 2024
This was referenced Nov 28, 2024
yannbf
added
the
patch:yes
Bugfix & documentation PR that need to be picked to main branch
label
Nov 29, 2024
Merged
14 tasks
yannbf
pushed a commit
that referenced
this pull request
Nov 29, 2024
Build: Attempt to fix Vite 6 sandboxes (cherry picked from commit a4ae081)
yannbf
pushed a commit
that referenced
this pull request
Nov 29, 2024
Build: Attempt to fix Vite 6 sandboxes (cherry picked from commit a4ae081)
github-actions
bot
added
the
patch:done
Patch/release PRs already cherry-picked to main/release branch
label
Nov 29, 2024
This was referenced Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
ci:daily
Run the CI jobs that normally run in the daily job.
patch:done
Patch/release PRs already cherry-picked to main/release branch
patch:yes
Bugfix & documentation PR that need to be picked to main branch
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
What I did
This will only pass once joshwooding/vite-plugin-react-docgen-typescript#40 is released
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.ts
Make sure this PR contains one of the labels below:
Available labels
bug
: Internal changes that fixes incorrect behavior.maintenance
: User-facing maintenance tasks.dependencies
: Upgrading (sometimes downgrading) dependencies.build
: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup
: Minor cleanup style change. Will not show up in release changelog.documentation
: Documentation only changes. Will not show up in release changelog.feature request
: Introducing a new feature.BREAKING CHANGE
: Changes that break compatibility in some way with current major version.other
: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/core
team here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>