Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Vite 6 #40

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Support Vite 6 #40

merged 2 commits into from
Nov 26, 2024

Conversation

yannbf
Copy link
Contributor

@yannbf yannbf commented Nov 26, 2024

Vite 6 has reached latest, our Storybook frameworks which depend on this plugin are crashing in installation because of dependency requiremets:

vite is listed by your project with version 6.0.0 (pe0090), which doesn't satisfy what @joshwooding/vite-plugin-react-docgen-typescript (via @storybook/react-native-web-vite) and other dependencies request (^5.0.0).

would be lovely to get this in 🫶

Copy link

changeset-bot bot commented Nov 26, 2024

⚠️ No Changeset found

Latest commit: 3ab64a3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@IanVS
Copy link
Collaborator

IanVS commented Nov 26, 2024

@yannbf mind updating the lockfile too?

@yannbf
Copy link
Contributor Author

yannbf commented Nov 26, 2024

@yannbf mind updating the lockfile too?

Done!

@IanVS IanVS requested a review from joshwooding November 26, 2024 14:33
@joshwooding joshwooding merged commit ea58da3 into joshwooding:main Nov 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants