-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release: Prerelease 8.5.0-alpha.13 #29744
Conversation
Build: Attempt to fix Vite 6 sandboxes
Portable stories: Support multiple annotation notations from preview
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
9 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 0174d20. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
Package BenchmarksCommit: The following packages have significant changes to their size or dependencies:
|
Before | After | Difference | |
---|---|---|---|
Dependency count | 109 | 93 | 🎉 -16 🎉 |
Self size | 41 KB | 41 KB | 0 B |
Dependency size | 18.70 MB | 16.16 MB | 🎉 -2.54 MB 🎉 |
Bundle Size Analyzer | Link | Link |
@storybook/react-vite
Before | After | Difference | |
---|---|---|---|
Dependency count | 103 | 87 | 🎉 -16 🎉 |
Self size | 12 KB | 12 KB | 0 B |
Dependency size | 18.56 MB | 16.01 MB | 🎉 -2.54 MB 🎉 |
Bundle Size Analyzer | Link | Link |
This is an automated pull request that bumps the version from
8.5.0-alpha.12
to8.5.0-alpha.13
.Once this pull request is merged, it will trigger a new release of version
8.5.0-alpha.13
.If you're not a core maintainer with permissions to release you can ignore this pull request.
To do
Before merging the PR, there are a few QA steps to go through:
And for each change below:
This is a list of all the PRs merged and commits pushed directly to
next
, that will be part of this release:If you've made any changes doing the above QA (change PR titles, revert PRs), manually trigger a re-generation of this PR with this workflow and wait for it to finish. It will wipe your progress in this to do, which is expected.
Feel free to manually commit any changes necessary to this branch after you've done the last re-generation, following the Make Manual Changes section in the docs, especially if you're making changes to the changelog.
When everything above is done:
Generated changelog
8.5.0-alpha.13
Greptile Summary
Here's my summary of the pull request changes:
Added support for multiple annotation notations in portable stories and upgraded react-docgen-typescript for Vite 6 compatibility.
portable-stories.ts
to handle both named and default exports simultaneously viacomposeConfigs
portable-stories.test.ts
to verify proper merging of different export types@joshwooding/vite-plugin-react-docgen-typescript
to v0.4.2 in React frameworks for Vite 6 supportsandbox-parts.ts
yarn.ts
The changes look appropriate for an alpha release, with proper test coverage and no breaking changes. The PR focuses on bug fixes and dependency updates to improve framework compatibility.