Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release: Prerelease 8.5.0-alpha.13 #29744

Merged
merged 9 commits into from
Nov 29, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Nov 29, 2024

This is an automated pull request that bumps the version from 8.5.0-alpha.12 to 8.5.0-alpha.13.
Once this pull request is merged, it will trigger a new release of version 8.5.0-alpha.13.
If you're not a core maintainer with permissions to release you can ignore this pull request.

To do

Before merging the PR, there are a few QA steps to go through:

  • Add the "freeze" label to this PR, to ensure it doesn't get automatically forced pushed by new changes.
  • Add the "ci:daily" label to this PR, to trigger the full test suite to run on this PR.

And for each change below:

  1. Ensure the change is appropriate for the version bump. E.g. patch release should only contain patches, not new or de-stabilizing features. If a change is not appropriate, revert the PR.
  2. Ensure the PR is labeled correctly with one of: "BREAKING CHANGE", "feature request", "bug", "maintenance", "dependencies", "documentation", "build", "unknown".
  3. Ensure the PR title is correct, and follows the format "[Area]: [Summary]", e.g. "React: Fix hooks in CSF3 render functions". If it is not correct, change the title in the PR.
    • Areas include: React, Vue, Core, Docs, Controls, etc.
    • First word of summary indicates the type: “Add”, “Fix”, “Upgrade”, etc.
    • The entire title should fit on a line

This is a list of all the PRs merged and commits pushed directly to next, that will be part of this release:

  • 🐛 Bug: Portable stories: Support multiple annotation notations from preview #29733 (will also be patched)
  • 🐛 Bug: React: Upgrade react-docgen-typescript to support Vite 6 #29724

If you've made any changes doing the above QA (change PR titles, revert PRs), manually trigger a re-generation of this PR with this workflow and wait for it to finish. It will wipe your progress in this to do, which is expected.

Feel free to manually commit any changes necessary to this branch after you've done the last re-generation, following the Make Manual Changes section in the docs, especially if you're making changes to the changelog.

When everything above is done:


Generated changelog

8.5.0-alpha.13

  • Portable stories: Support multiple annotation notations from preview - #29733, thanks @yannbf!
  • React: Upgrade react-docgen-typescript to support Vite 6 - #29724, thanks @yannbf!

Greptile Summary

Here's my summary of the pull request changes:

Added support for multiple annotation notations in portable stories and upgraded react-docgen-typescript for Vite 6 compatibility.

  • Modified portable-stories.ts to handle both named and default exports simultaneously via composeConfigs
  • Added test coverage in portable-stories.test.ts to verify proper merging of different export types
  • Updated @joshwooding/vite-plugin-react-docgen-typescript to v0.4.2 in React frameworks for Vite 6 support
  • Removed unnecessary Vite workarounds from sandbox configuration in sandbox-parts.ts
  • Simplified yarn resolutions by removing outdated version constraints in yarn.ts

The changes look appropriate for an alpha release, with proper test coverage and no breaking changes. The PR focuses on bug fixes and dependency updates to improve framework compatibility.

@github-actions github-actions bot added the release For PRs that trigger new releases. Automated label Nov 29, 2024
@yannbf yannbf added ci:daily Run the CI jobs that normally run in the daily job. freeze Freeze the Release PR with this label labels Nov 29, 2024
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

9 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@yannbf yannbf added ci:daily Run the CI jobs that normally run in the daily job. and removed ci:daily Run the CI jobs that normally run in the daily job. labels Nov 29, 2024
Copy link

nx-cloud bot commented Nov 29, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 0174d20. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@storybook-pr-benchmarking
Copy link

Package Benchmarks

Commit: 0174d20, ran on 29 November 2024 at 09:03:21 UTC

The following packages have significant changes to their size or dependencies:

@storybook/react-native-web-vite

Before After Difference
Dependency count 109 93 🎉 -16 🎉
Self size 41 KB 41 KB 0 B
Dependency size 18.70 MB 16.16 MB 🎉 -2.54 MB 🎉
Bundle Size Analyzer Link Link

@storybook/react-vite

Before After Difference
Dependency count 103 87 🎉 -16 🎉
Self size 12 KB 12 KB 0 B
Dependency size 18.56 MB 16.01 MB 🎉 -2.54 MB 🎉
Bundle Size Analyzer Link Link

@yannbf yannbf merged commit 3498a2e into next-release Nov 29, 2024
111 checks passed
@yannbf yannbf deleted the version-non-patch-from-8.5.0-alpha.12 branch November 29, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:daily Run the CI jobs that normally run in the daily job. freeze Freeze the Release PR with this label release For PRs that trigger new releases. Automated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants