Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync #2

Merged
merged 10 commits into from
Jan 18, 2020
Merged

sync #2

merged 10 commits into from
Jan 18, 2020

Conversation

sssash18
Copy link
Owner

Fixes #0000 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

simonastefan and others added 10 commits January 17, 2020 21:19
The most important improvement is the removal of assert_page_reloads statement.
This block of code never executed and just delayed Travis for ~1min every build.

The second improvement is the addition of the "setup" function.
Instead of writing login logic in every test, now before every test the
"setup" function will run and log in the user.

Part of #7272
* Added 'spamaway_textarea blank error' test

* Added empty line between the test

* Added 'do'
* Fixes #7263 At location button to dashboard sidebar

* Fixes #7263 At location button to dashboard sidebar

* Trying new code to fix issue
* [fixed] issue #7269

* [fixed] failing test cases for #7269

* [fixed] failing test cases for #7269
Unit tests:
 - "sanitizing comment body for XSS"
 - "should close incomplete tags"

Resolves #3630 #3553
* add tests for wiki editors

* fix test names
@sssash18 sssash18 merged commit 1a1da62 into sssash18:master Jan 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants