REFACTOR: post_test.rb [Travis optimization] #7275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The most important improvement is the removal of assert_page_reloads statement. This block of code never executed and just delayed Travis for ~1min every build. The second improvement is the addition of the "setup" function. Instead of writing login logic in every test, now before every test the "setup" function will run and log in the user. Part of #7272
Codecov Report
@@ Coverage Diff @@
## master #7275 +/- ##
==========================================
- Coverage 81.59% 81.56% -0.04%
==========================================
Files 97 97
Lines 5602 5602
==========================================
- Hits 4571 4569 -2
- Misses 1031 1033 +2
|
Screenshots 📸 (click to expand)7275-test_questions.png7275-test_embeddable_grids.png7275-test_signup.png7275-test_viewing_the_settings_page.png7275-test_tag_by_author_page.png7275-test_wiki_page_with_inline_grids.png7275-test_stats.png7275-test_viewing_the_dashboard.png7275-test_searching_an_item_from_the_homepage.png7275-test_signup_modal_form_validation.png7275-test_tag_stats.png7275-test_login_modal_form_validation.png7275-test_questions_shadow.png7275-test_login_modal.png7275-test_profile_page.png7275-test_comments.png7275-test_tags.png7275-test_signup_modal.png7275-test_wiki.png7275-test_methods.png7275-test_tag_page.png7275-test_blog_page_with_location_modal.png7275-test_tag_wildcard.png7275-test_signup_modal_disabled_submit_button_on_empty_username.png7275-test_embeddable_thumbnail_grids.png7275-test_front_page_with_navbar_search_autocomplete.png7275-test_spam_moderation_page.png7275-test_login.png7275-test_viewing_the_dropdown_menu.png7275-test_viewing_question_post.png7275-test_mobile_displays.png7275-test_simple-data-grapher_powertag.png7275-test_front.png7275-test_question_page.png7275-test_tag_contributors_page.png7275-test_blog.png7275-test_people.png7275-test_wiki_revisions.pngLearn about automated screenshots Generated by 🚫 Danger |
|
I was right! The new build time now is 9min 20secs compared to 10min 48sec. 🚀 |
|
Great! Is this ready for a merge, then? Great work! 🚀 |
|
I am going to bed though... i'll check in the morning!! Thank you!! |
|
Yes it is :) |
|
Jeff I think you should sleep unless you are on a workshop outside US. It must be 12:30 approxs midnight there |
|
thanks all |
SidharthBansal
approved these changes
Jan 17, 2020
|
Fantastic. Thank you!!! |
|
Great!
…On Fri, Jan 17, 2020 at 9:20 PM Jeffrey Warren ***@***.***> wrote:
Fantastic. Thank you!!!
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#7275?email_source=notifications&email_token=AFAAEQZ5ICNV7KFRYYOHSV3Q6HHTXA5CNFSM4KICUAE2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJIDDVI#issuecomment-575680981>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFAAEQ6FMMZZN6L3YV5VQ33Q6HHTXANCNFSM4KICUAEQ>
.
|
|
@jywarren thank you for your time, not me. |
|
Thanks everyone for their effort. I think we will need a small system tests
pr for approving your system test 2 along with these 2 merged prs
…On Fri, Jan 17, 2020 at 9:22 PM Vladimir Mikulic ***@***.***> wrote:
@jywarren <https://github.com/jywarren> thank you for your time, not me.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#7275?email_source=notifications&email_token=AFAAEQZ4DKP7UOT35FX366TQ6HH2NA5CNFSM4KICUAE2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJIDJUY#issuecomment-575681747>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFAAEQ6VAEGJQXU5POOVYFTQ6HH2NANCNFSM4KICUAEQ>
.
|
|
What do you think?
On Fri, Jan 17, 2020 at 9:25 PM Sidharth Bansal <
bansal.sidharthcode@gmail.com> wrote:
… Thanks everyone for their effort. I think we will need a small system
tests pr for approving your system test 2 along with these 2 merged prs
On Fri, Jan 17, 2020 at 9:22 PM Vladimir Mikulic ***@***.***>
wrote:
> @jywarren <https://github.com/jywarren> thank you for your time, not me.
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <#7275?email_source=notifications&email_token=AFAAEQZ4DKP7UOT35FX366TQ6HH2NA5CNFSM4KICUAE2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJIDJUY#issuecomment-575681747>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AFAAEQ6VAEGJQXU5POOVYFTQ6HH2NANCNFSM4KICUAEQ>
> .
>
|
|
It's fine by me, thank you for acknowledging my work 👍 |
vinitshahdeo
pushed a commit
to vinitshahdeo/plots2
that referenced
this pull request
Feb 1, 2020
The most important improvement is the removal of assert_page_reloads statement. This block of code never executed and just delayed Travis for ~1min every build. The second improvement is the addition of the "setup" function. Instead of writing login logic in every test, now before every test the "setup" function will run and log in the user. Part of publiclab#7272
NitinBhasneria
pushed a commit
to NitinBhasneria/plots2
that referenced
this pull request
Feb 5, 2020
The most important improvement is the removal of assert_page_reloads statement. This block of code never executed and just delayed Travis for ~1min every build. The second improvement is the addition of the "setup" function. Instead of writing login logic in every test, now before every test the "setup" function will run and log in the user. Part of publiclab#7272
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The most important improvement is the removal of assert_page_reloads
statement. This block of code never executed and just delayed Travis
for ~1min(Capybara timeout rule) every build.
The second improvement is the addition of the "setup" function.
Instead of writing login logic in every test, now before every test the
"setup" function will run and log in the user.
Part of #7272