Bump leaflet-environmental-layers from 2.1.7 to 2.1.9 #7272

dependabot-preview · 2020-01-17T00:20:41Z

Bumps leaflet-environmental-layers from 2.1.7 to 2.1.9.

Commits

See full diff in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot will merge this PR once CI passes on it, as requested by @jywarren.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
@dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in the .dependabot/config.yml file in this repo:

Update frequency
Automerge options (never/patch/minor, and dev/runtime dependencies)
Out-of-range updates (receive only lockfile updates, if desired)
Security updates (receive only security updates, if desired)

codecov · 2020-01-17T01:03:03Z

Codecov Report

Merging #7272 into master will decrease coverage by 1.55%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #7272      +/-   ##
==========================================
- Coverage    81.6%   80.04%   -1.56%     
==========================================
  Files          97       97              
  Lines        5599     5619      +20     
==========================================
- Hits         4569     4498      -71     
- Misses       1030     1121      +91

Impacted Files	Coverage Δ
app/channels/application_cable/connection.rb	`0% <0%> (-100%)`	⬇️
app/channels/application_cable/channel.rb	`0% <0%> (-100%)`	⬇️
app/channels/user_notification_channel.rb	`0% <0%> (-83.34%)`	⬇️
app/channels/user_channel.rb	`0% <0%> (-83.34%)`	⬇️
app/channels/room_channel.rb	`0% <0%> (-71.43%)`	⬇️
app/controllers/questions_controller.rb	`81.57% <0%> (-9.22%)`	⬇️
app/services/execute_search.rb	`88.88% <0%> (-5.56%)`	⬇️
app/controllers/tag_controller.rb	`74.68% <0%> (-5.32%)`	⬇️
app/models/tag_selection.rb	`92% <0%> (-4%)`	⬇️
app/api/srch/search.rb	`64.7% <0%> (-3.93%)`	⬇️
... and 5 more

jywarren · 2020-01-17T01:15:12Z

Hmm... @Uzay-G @VladimirMikulic are our new system tests making the travis run really really long?

VladimirMikulic · 2020-01-17T01:16:58Z

@jywarren well, the system tests are the slowest ones. The more we add them, the slower our Travis is.

jywarren · 2020-01-17T01:21:53Z

Maybe we overdid it! Let's analyze a bit... no worries!

VladimirMikulic · 2020-01-17T01:26:54Z

That's true, we literally destroyed #5316 in 24 hours.

dependabot-preview · 2020-01-17T01:27:52Z

One of your CI runs failed on this pull request, so Dependabot won't merge it.

continuous-integration/travis-ci/pr

Dependabot will still automatically merge this pull request if you amend it and your tests pass.

VladimirMikulic · 2020-01-17T01:29:55Z

This Travis run (system tests) took ~28min. How long does it usually take? Are we really that slow?

jywarren · 2020-01-17T01:47:04Z

It's usually 8-12 minutes. But even with say, 6 new system tests, i don't think it could've gone that long. And this happened before once, so there may be something we can configure differently to fix this. Let's do 2 things:

i'll look for the last time system tests ran real long and see what we changed
let's review the most recent system tests and the Travis runtimes to see if it was one in particular or just each one adding more time?

Thanks for looking at this, and don't worry, we'll figure it out!

jywarren · 2020-01-17T01:47:27Z

Oh, and 3. we can look through the Travis logs to see if there's a particular test that's causing a lot of delay.

jywarren · 2020-01-17T01:51:06Z

I think this was where we had a 24 minute runtime on system tests: #5683

VladimirMikulic · 2020-01-17T01:51:32Z

Then you are right, we've slowed down by more than 100%! I'll see what I can do. Thanks.

VladimirMikulic · 2020-01-17T02:17:25Z

@jywarren take a look at this

VladimirMikulic · 2020-01-17T02:18:29Z

I think that is what we are looking for, Capybara finds 2 ambiguous elements (it can't decide between the 2) so it delays.

jywarren · 2020-01-17T02:19:55Z

Ooooooohhhhhh great find....! Well, let's test by narrowing that selector somehow and opening a PR?

Fingers 🤞 !!!

jywarren · 2020-01-17T02:20:00Z


ERROR["test_signup_modal", #<Minitest::Reporters::Suite:0x00007fdbd4de83b8 @name="ScreenshotsTest">, 584.643272902]
 test_signup_modal#ScreenshotsTest (584.64s)
Minitest::UnexpectedError:         Capybara::Ambiguous: Ambiguous match, found 2 elements matching link or button "Sign up"
            test/system/screenshots_test.rb:13:in `block in <class:ScreenshotsTest>'
[Screenshot]: tmp/screenshots/failures_test_signup_modal_disabled_submit_button_on_empty_username.png
ERROR["test_signup_modal_disabled_submit_button_on_empty_username", #<Minitest::Reporters::Suite:0x00007fdbd54f16f0 @name="ScreenshotsTest">, 645.063963948]
 test_signup_modal_disabled_submit_button_on_empty_username#ScreenshotsTest (645.06s)
Minitest::UnexpectedError:         Capybara::Ambiguous: Ambiguous match, found 2 elements matching link or button "Sign up"
            test/system/screenshots_test.rb:42:in `block in <class:ScreenshotsTest>'
[Screenshot]: tmp/screenshots/failures_test_signup_modal_form_validation.png
ERROR["test_signup_modal_form_validation", #<Minitest::Reporters::Suite:0x00007fdbd6682ef0 @name="ScreenshotsTest">, 705.557812964]
 test_signup_modal_form_validation#ScreenshotsTest (705.56s)
Minitest::UnexpectedError:         Capybara::Ambiguous: Ambiguous match, found 2 elements matching link or button "Sign up"
            test/system/screenshots_test.rb:20:in `block in <class:ScreenshotsTest>'
[Screenshot]: tmp/screenshots/failures_test_spam_moderation_page.png
ERROR["test_spam_moderation_page", #<Minitest::Reporters::Suite:0x0000559c50695db0 @name="ScreenshotsTest">, 766.2644276820001]
 test_spam_moderation_page#ScreenshotsTest (766.26s)
Minitest::UnexpectedError:         Capybara::Ambiguous: Ambiguous match, found 2 elements matching link or button "Log in"
            test/system/screenshots_test.rb:206:in `block in <class:ScreenshotsTest>'

VladimirMikulic · 2020-01-17T02:20:29Z

Let me clarify, we have 2 elements on the page and they both say "Log in"/"Sign up" the first one triggers the login/signup modal and the other one submits the form.

VladimirMikulic · 2020-01-17T02:20:41Z

I'll send a PR for this.

VladimirMikulic · 2020-01-17T02:58:54Z

So to summarise, I've refactored the newly added code and some of the old one.
Using click_on is a bad practise if the element is not unique!

Capybara has a certain threshold and it will put up with our click_ons, but once we have too many of them and elements are not unique it will cause problems like this one.

I guess we learned something new today!

@Uzay-G you'll have to sacrifice the readability a bit because of this ;)

dependabot-preview · 2020-01-17T03:59:50Z

OK, I won't notify you again about this release, but will get in touch when a new version is available.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

jywarren · 2020-01-17T04:00:40Z

@dependabot recreate

dependabot-preview · 2020-01-17T04:00:42Z

Looks like this PR is closed. If you re-open it I'll rebase it as long as no-one else has edited it (you can use @dependabot reopen if the branch has been deleted).

jywarren · 2020-01-17T04:01:04Z

@dependabot reopen

jywarren · 2020-01-17T04:01:42Z

@dependabot rebase

jywarren · 2020-01-17T04:36:03Z

@dependabot recreate

The most important improvement is the removal of assert_page_reloads statement. This block of code never executed and just delayed Travis for ~1min every build. The second improvement is the addition of the "setup" function. Instead of writing login logic in every test, now before every test the "setup" function will run and log in the user. Part of #7272

jywarren · 2020-01-17T18:07:08Z

@dependabot rebase

Bumps [leaflet-environmental-layers](https://github.com/publiclab/leaflet-environmental-layers) from 2.1.7 to 2.1.9. - [Release notes](https://github.com/publiclab/leaflet-environmental-layers/releases) - [Commits](https://github.com/publiclab/leaflet-environmental-layers/commits) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

jywarren · 2020-01-17T20:12:49Z

Hmm. I don't quite get it. @VladimirMikulic is dependabot not really rebasing here? We keep timing out at 50 minutes. I'm not quite sure why.

Look, it seems not: https://github.com/publiclab/plots2/commits/dependabot/npm_and_yarn/leaflet-environmental-layers-2.1.9

I'm going to make this change manually, and close this.

VladimirMikulic · 2020-01-17T20:18:46Z

It does rebase it, but our screenshot system tests time out for some reason.

VladimirMikulic · 2020-01-17T20:21:05Z

Apparently going to URLs causes a delay (visit "/something")

VladimirMikulic · 2020-01-17T20:26:29Z

From the official docs: https://ruby-doc.org/stdlib-2.1.2/libdoc/net/http/rdoc/Net/HTTP.html

"If the HTTP object cannot read data in this many seconds, it raises a Net::ReadTimeout exception. The default value is 60 seconds."

jywarren · 2020-01-19T00:32:46Z

moving to #7299

The most important improvement is the removal of assert_page_reloads statement. This block of code never executed and just delayed Travis for ~1min every build. The second improvement is the addition of the "setup" function. Instead of writing login logic in every test, now before every test the "setup" function will run and log in the user. Part of publiclab#7272

dependabot-preview bot added dependencies Pull requests that update a dependency file JavaScript labels Jan 17, 2020

jywarren approved these changes Jan 17, 2020

View reviewed changes

jywarren mentioned this pull request Jan 17, 2020

Brainstorm a list of critical full-stack system tests we should add #5316

Closed

13 tasks

VladimirMikulic mentioned this pull request Jan 17, 2020

FIX: Slow Travis runtime #7274

Merged

jywarren closed this in #7274 Jan 17, 2020

dependabot-preview bot deleted the dependabot/npm_and_yarn/leaflet-environmental-layers-2.1.9 branch January 17, 2020 04:00

dependabot-preview bot reopened this Jan 17, 2020

dependabot-preview bot restored the dependabot/npm_and_yarn/leaflet-environmental-layers-2.1.9 branch January 17, 2020 04:01

dependabot-preview bot force-pushed the dependabot/npm_and_yarn/leaflet-environmental-layers-2.1.9 branch from 60c8801 to 346e9eb Compare January 17, 2020 04:02

VladimirMikulic mentioned this pull request Jan 17, 2020

REFACTOR: post_test.rb [Travis optimization] #7275

Merged

dependabot-preview bot force-pushed the dependabot/npm_and_yarn/leaflet-environmental-layers-2.1.9 branch from 346e9eb to e580fad Compare January 17, 2020 18:08

jywarren mentioned this pull request Jan 19, 2020

version bump LEL 2.1.9 #7299

Closed

jywarren closed this Jan 19, 2020

dependabot-preview bot deleted the dependabot/npm_and_yarn/leaflet-environmental-layers-2.1.9 branch January 19, 2020 00:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump leaflet-environmental-layers from 2.1.7 to 2.1.9 #7272

Bump leaflet-environmental-layers from 2.1.7 to 2.1.9 #7272

dependabot-preview bot commented Jan 17, 2020 •

edited

Loading

codecov bot commented Jan 17, 2020 •

edited

Loading

jywarren commented Jan 17, 2020

VladimirMikulic commented Jan 17, 2020

jywarren commented Jan 17, 2020

VladimirMikulic commented Jan 17, 2020

dependabot-preview bot commented Jan 17, 2020

VladimirMikulic commented Jan 17, 2020

jywarren commented Jan 17, 2020

jywarren commented Jan 17, 2020

jywarren commented Jan 17, 2020

VladimirMikulic commented Jan 17, 2020

VladimirMikulic commented Jan 17, 2020

VladimirMikulic commented Jan 17, 2020

jywarren commented Jan 17, 2020

jywarren commented Jan 17, 2020

VladimirMikulic commented Jan 17, 2020

VladimirMikulic commented Jan 17, 2020

VladimirMikulic commented Jan 17, 2020 •

edited

Loading

dependabot-preview bot commented Jan 17, 2020

jywarren commented Jan 17, 2020

dependabot-preview bot commented Jan 17, 2020

jywarren commented Jan 17, 2020

jywarren commented Jan 17, 2020

jywarren commented Jan 17, 2020

jywarren commented Jan 17, 2020

jywarren commented Jan 17, 2020

VladimirMikulic commented Jan 17, 2020

VladimirMikulic commented Jan 17, 2020 •

edited

Loading

VladimirMikulic commented Jan 17, 2020

jywarren commented Jan 19, 2020

Bump leaflet-environmental-layers from 2.1.7 to 2.1.9 #7272

Bump leaflet-environmental-layers from 2.1.7 to 2.1.9 #7272

Conversation

dependabot-preview bot commented Jan 17, 2020 • edited Loading

codecov bot commented Jan 17, 2020 • edited Loading

Codecov Report

jywarren commented Jan 17, 2020

VladimirMikulic commented Jan 17, 2020

jywarren commented Jan 17, 2020

VladimirMikulic commented Jan 17, 2020

dependabot-preview bot commented Jan 17, 2020

VladimirMikulic commented Jan 17, 2020

jywarren commented Jan 17, 2020

jywarren commented Jan 17, 2020

jywarren commented Jan 17, 2020

VladimirMikulic commented Jan 17, 2020

VladimirMikulic commented Jan 17, 2020

VladimirMikulic commented Jan 17, 2020

jywarren commented Jan 17, 2020

jywarren commented Jan 17, 2020

VladimirMikulic commented Jan 17, 2020

VladimirMikulic commented Jan 17, 2020

VladimirMikulic commented Jan 17, 2020 • edited Loading

dependabot-preview bot commented Jan 17, 2020

jywarren commented Jan 17, 2020

dependabot-preview bot commented Jan 17, 2020

jywarren commented Jan 17, 2020

jywarren commented Jan 17, 2020

jywarren commented Jan 17, 2020

jywarren commented Jan 17, 2020

jywarren commented Jan 17, 2020

VladimirMikulic commented Jan 17, 2020

VladimirMikulic commented Jan 17, 2020 • edited Loading

VladimirMikulic commented Jan 17, 2020

jywarren commented Jan 19, 2020

dependabot-preview bot commented Jan 17, 2020 •

edited

Loading

codecov bot commented Jan 17, 2020 •

edited

Loading

VladimirMikulic commented Jan 17, 2020 •

edited

Loading

VladimirMikulic commented Jan 17, 2020 •

edited

Loading