-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #7263 At location button to dashboard sidebar #7265
Conversation
Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help. |
Codecov Report
@@ Coverage Diff @@
## master #7265 +/- ##
=========================================
Coverage ? 78.11%
=========================================
Files ? 97
Lines ? 5602
Branches ? 0
=========================================
Hits ? 4376
Misses ? 1226
Partials ? 0
|
Ok I took a look at everything, apparently that template gets rendered even when a user isn't logged in, but if there's no user then the button gives an error! We can solve this by checking if there is a user logged in! This is the same code as before, but wrapped in a ruby if statement:
|
Screenshots 📸 (click to expand)7265-test_questions.png7265-test_embeddable_grids.png7265-test_signup.png7265-test_viewing_the_settings_page.png7265-test_tag_by_author_page.png7265-test_wiki_page_with_inline_grids.png7265-test_stats.png7265-test_viewing_the_dashboard.png7265-test_searching_an_item_from_the_homepage.png7265-test_signup_modal_form_validation.png7265-test_tag_stats.png7265-test_login_modal_form_validation.png7265-test_questions_shadow.png7265-test_login_modal.png7265-test_profile_page.png7265-test_comments.png7265-test_tags.png7265-test_signup_modal.png7265-test_wiki.png7265-test_methods.png7265-test_tag_page.png7265-test_blog_page_with_location_modal.png7265-test_tag_wildcard.png7265-test_signup_modal_disabled_submit_button_on_empty_username.png7265-test_embeddable_thumbnail_grids.png7265-test_front_page_with_navbar_search_autocomplete.png7265-test_spam_moderation_page.png7265-test_login.png7265-test_viewing_the_dropdown_menu.png7265-test_viewing_question_post.png7265-test_mobile_displays.png7265-test_simple-data-grapher_powertag.png7265-test_front.png7265-test_question_page.png7265-test_tag_contributors_page.png7265-test_blog.png7265-test_people.png7265-test_wiki_revisions.pngLearn about automated screenshots Generated by 🚫 Danger |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!!
Fantastic 🎉 🎉 this is great 🚀 |
Congrats on merging your first pull request! 🙌🎉⚡️ Help others take their first stepNow that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌 Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕 People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉 Read about how to help support another newcomer here, or find other ways to offer mutual support here. |
…ab#7265) * Fixes publiclab#7263 At location button to dashboard sidebar * Fixes publiclab#7263 At location button to dashboard sidebar * Trying new code to fix issue
…ab#7265) * Fixes publiclab#7263 At location button to dashboard sidebar * Fixes publiclab#7263 At location button to dashboard sidebar * Trying new code to fix issue
Fixes #7263 At location button to dashboard sidebar
🔗 Link to Issue Issue
As mentioned in the issue, I have changed the file
and added the code
This leads to changes in Side-bar of Dashboard.
![Screenshot from 2020-01-17 00-39-19](https://user-images.githubusercontent.com/38528640/72556174-14af4e00-38c4-11ea-8146-515f3249e857.png)
![Screenshot from 2020-01-16 23-30-33](https://user-images.githubusercontent.com/38528640/72556516-c8b0d900-38c4-11ea-869d-7fed4e0cf9a1.png)
Before changes . (This is how it looks now )
After adding the changes ( This is how it looks after changes )
Both pictures are screenshots from my localhost
The files that differ are
![Screenshot from 2020-01-17 00-42-16](https://user-images.githubusercontent.com/38528640/72556341-6b1c8c80-38c4-11ea-9758-ffdd11ed5f5a.png)