ADD: Rich text editor image upload system tests

[VladimirMikulic]

Part of #5316

[codecov]

Codecov Report

Merging #7273 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #7273      +/-   ##
=========================================
+ Coverage   81.59%   81.6%   +<.01%     
=========================================
  Files          97      97              
  Lines        5602    5599       -3     
=========================================
- Hits         4571    4569       -2     
+ Misses       1031    1030       -1

Impacted Files	Coverage Δ
app/models/tag.rb	97.46% <ø> (+0.46%)	⬆️
app/controllers/user_sessions_controller.rb	66.45% <0%> (-1.25%)	⬇️
app/controllers/users_controller.rb	81.69% <0%> (+0.35%)	⬆️
app/models/spamaway.rb	94.87% <0%> (+2.56%)	⬆️

[jywarren]

Restarting to see if CodeCov resolves differently :-/

[VladimirMikulic]

@jywarren it does :-)

[jywarren]

a little bit disconcerting, but i'm OK with it for now! Let's do think on how to fix it, though. First maybe we need to document it thoroughly.

[jywarren]

Thank you!!!

[VladimirMikulic]

@jywarren Please ask and I will explain. The thing that I did here is that I refactored drop_in_dropzone to accept an additional parameter dropzoneSelector. This way function is reusable.

Thanks.

[VladimirMikulic]

I should have mentioned this in the commit message. I apologise.

[jywarren]

No, sorry, i was referring to the uncertainty about CodeCov! my bad! i think it must be some timing/ordering issue which is making it report in coverage non-deterministically. or at least inconsistently.

[VladimirMikulic]

Oh, so it's CodeCov. How can I help you with CodeCov?

[Uzay-G]

@jywarren what is wrong with the coverage?

[jywarren]

It seems to be quite inconsistent. We are bouncing between 60-80% coverage. And, re-running Travis can result in different outcomes, as happened here.