Fix location modal jumping off-screen at small screen sizes #7284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7284 +/- ##
=========================================
+ Coverage 81.59% 81.6% +<.01%
=========================================
Files 97 97
Lines 5602 5599 -3
=========================================
- Hits 4571 4569 -2
+ Misses 1031 1030 -1
|
jywarren
approved these changes
Jan 17, 2020
|
Great! Thanks!! |
vinitshahdeo
pushed a commit
to vinitshahdeo/plots2
that referenced
this pull request
Feb 1, 2020
NitinBhasneria
pushed a commit
to NitinBhasneria/plots2
that referenced
this pull request
Feb 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7283 (<=== Add issue number here)
I'm not sure where the negative margin is coming from, but setting it to 0 for
#blurred-location-modal .modal-contentfixes the problem.