Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused setuptools dependencies #62

Closed
6 tasks done
jameslamb opened this issue May 21, 2024 · 3 comments
Closed
6 tasks done

Remove unused setuptools dependencies #62

jameslamb opened this issue May 21, 2024 · 3 comments
Assignees

Comments

@jameslamb
Copy link
Member

jameslamb commented May 21, 2024

Description

Working on #31, I found that cudf was carrying a dependency on setuptools that it didn't need. See rapidsai/cudf#15736.

Noticed something similar in cuml today: rapidsai/cuml#5901.

I suspect there might be other RAPIDS libraries that also have an unnecessary setuptools dependency, left over from earlier approaches to building them.

Benefits of this work

  • removes an unnecessary dependency, with all the benefits that that entails

Acceptance Criteria

  • every setuptools dependency across RAPIDS is used

Approach

Browse through https://github.com/search?q=org%3Arapidsai%20setuptools&type=code.

Repos with setuptools declared only in conda build recipes or dependencies.yaml (i.e. never directly imported, not referenced in [build-system] table in pyproject.toml) are good candidates. Add a tasklist here listing the repos to investigate.

For any repos that look like they're carrying around unnecessary setuptools dependencies, remove those dependencies.

Notes

@jameslamb
Copy link
Member Author

After a search of the rapidsai org on GitHub, I think only 4 more projects (cugraph, cuspatial, kvikio, raft) are carrying unnecessary setuptools dependencies for some packages.

I've updated the task list in the description, and I'll put up PRs for all of those today.

rapids-bot bot pushed a commit to rapidsai/cuspatial that referenced this issue May 30, 2024
Contributes to rapidsai/build-planning#62.

It looks like this project's wheels and conda recipes have unnecessary dependencies on `setuptools`. I suspect those are left over from before the project was cut over to `scikit-build-core`.

This proposes removing those.

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Mark Harris (https://github.com/harrism)
  - Jake Awe (https://github.com/AyodeAwe)

URL: #1389
rapids-bot bot pushed a commit to rapidsai/kvikio that referenced this issue May 30, 2024
Contributes to rapidsai/build-planning#62.

It looks like this some of the `kvikio` conda package recipe has an unnecessary dependency on `setuptools`. I suspect that's left over from before the project was cut over to `scikit-build-core`.

This proposes removing it.

## Notes for Reviewers

How I confirmed there were no direct uses of `setuptools` in  this project:

```shell
git grep -i setuptools
```

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Jake Awe (https://github.com/AyodeAwe)

URL: #385
rapids-bot bot pushed a commit to rapidsai/raft that referenced this issue May 30, 2024
Contributes to rapidsai/build-planning#62.

It looks like this some of this project's `conda` recipes have unnecessary dependencies on `setuptools`. I suspect those are left over from before the project was cut over to `scikit-build-core`.

## Notes for Reviewers

How I confirmed there were no direct uses of `setuptools` in `pylibraft` and `raft-dask`:

```shell
git grep -i setuptools
```

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Jake Awe (https://github.com/AyodeAwe)

URL: #2343
rapids-bot bot pushed a commit to rapidsai/cugraph that referenced this issue May 30, 2024
Contributes to rapidsai/build-planning#62.

It looks like the `cugraph` and `pylibcugraph` wheels and conda recipes have unnecessary dependencies on `setuptools` and `wheel`. I suspect those are left over from before those libraries were cut over to `scikit-build-core`.

This proposes removing those.

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Jake Awe (https://github.com/AyodeAwe)
  - Rick Ratzel (https://github.com/rlratzel)

URL: #4448
@jameslamb
Copy link
Member Author

I did one more quick GitHub search, don't see any other cases that need to be addressed. This is complete 😁

@jakirkham
Copy link
Member

Thanks James! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants