Skip to content

Commit

Permalink
remove unnecessary 'setuptools' dependency (#385)
Browse files Browse the repository at this point in the history
Contributes to rapidsai/build-planning#62.

It looks like this some of the `kvikio` conda package recipe has an unnecessary dependency on `setuptools`. I suspect that's left over from before the project was cut over to `scikit-build-core`.

This proposes removing it.

## Notes for Reviewers

How I confirmed there were no direct uses of `setuptools` in  this project:

```shell
git grep -i setuptools
```

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Jake Awe (https://github.com/AyodeAwe)

URL: #385
  • Loading branch information
jameslamb authored May 30, 2024
1 parent 5e9f0c8 commit 2b3cbd0
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 2 deletions.
1 change: 0 additions & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ The Python packages depends on the following packages:

* Cython
* Pip
* Setuptools

For testing:
* pytest
Expand Down
1 change: 0 additions & 1 deletion conda/recipes/kvikio/meta.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@ requirements:
- {{ stdlib("c") }}
host:
- python
- setuptools
- pip
- cython >=3.0.0
{% if cuda_major == "11" %}
Expand Down

0 comments on commit 2b3cbd0

Please sign in to comment.