Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unnecessary 'setuptools' dependency #385

Merged
merged 1 commit into from
May 30, 2024

Conversation

jameslamb
Copy link
Member

@jameslamb jameslamb commented May 28, 2024

Contributes to rapidsai/build-planning#62.

It looks like this some of the kvikio conda package recipe has an unnecessary dependency on setuptools. I suspect that's left over from before the project was cut over to scikit-build-core.

This proposes removing it.

Notes for Reviewers

How I confirmed there were no direct uses of setuptools in this project:

git grep -i setuptools

@jameslamb jameslamb added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels May 28, 2024
@jameslamb jameslamb changed the title WIP: remove unnecessary 'setuptools' dependency remove unnecessary 'setuptools' dependency May 28, 2024
@jameslamb jameslamb marked this pull request as ready for review May 28, 2024 16:50
@jameslamb jameslamb requested a review from a team as a code owner May 28, 2024 16:50
@madsbk
Copy link
Member

madsbk commented May 29, 2024

There is a reference to setuptools here: https://github.com/rapidsai/kvikio/blob/branch-24.08/ci/release/update-version.sh#L27

@jameslamb
Copy link
Member Author

There is a reference to setuptools here:

Thanks for checking!

I believe those update-version.sh scripts are run manually by ops when cutting new release branches (@raydouglass or @AyodeAwe could confirm), and that they don't rely on projects' dependency metadata (conda recipes, pyproject.toml, dependencies.yaml) to provide it.

@jameslamb
Copy link
Member Author

Thanks for your attention to detail @madsbk ... based on @AyodeAwe 's 👍🏻 on #385 (comment), I think this is safe to merge and the setuptools reference in update-version.sh should remain where it is.

@jameslamb
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit 2b3cbd0 into rapidsai:branch-24.08 May 30, 2024
35 checks passed
@jameslamb jameslamb deleted the remove-setuptools branch May 30, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conda improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants