Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unnecessary 'setuptools' dependencies #1389

Merged
merged 2 commits into from
May 30, 2024

Conversation

jameslamb
Copy link
Member

@jameslamb jameslamb commented May 28, 2024

Contributes to rapidsai/build-planning#62.

It looks like this project's wheels and conda recipes have unnecessary dependencies on setuptools. I suspect those are left over from before the project was cut over to scikit-build-core.

This proposes removing those.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

Notes for Reviewers

How I confirmed there were no direct uses of setuptools in the project:

git grep -i setuptools

@jameslamb jameslamb added 2 - In Progress Currenty a work in progress improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 28, 2024
@github-actions github-actions bot added conda Related to conda and conda configuration Python Related to Python code labels May 28, 2024
@jameslamb jameslamb changed the title WIP: remove unnecessary 'setuptools' dependencies remove unnecessary 'setuptools' dependencies May 28, 2024
@jameslamb jameslamb added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currenty a work in progress labels May 28, 2024
@jameslamb jameslamb marked this pull request as ready for review May 28, 2024 21:42
@jameslamb jameslamb requested review from a team as code owners May 28, 2024 21:42
@jameslamb jameslamb requested review from trxcllnt and harrism May 28, 2024 21:42
@jameslamb
Copy link
Member Author

I believe the failing conda-notebook-tests job (build link) will be fixed once branch-24.06 is forward-merged into branch-24.08 (#1388).

@jameslamb
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit a81f016 into rapidsai:branch-24.08 May 30, 2024
70 checks passed
@jameslamb jameslamb deleted the remove-setuptools branch May 30, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team conda Related to conda and conda configuration improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Related to Python code
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

3 participants