Skip to content

Commit

Permalink
remove unnecessary 'setuptools' dependencies (#1389)
Browse files Browse the repository at this point in the history
Contributes to rapidsai/build-planning#62.

It looks like this project's wheels and conda recipes have unnecessary dependencies on `setuptools`. I suspect those are left over from before the project was cut over to `scikit-build-core`.

This proposes removing those.

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Mark Harris (https://github.com/harrism)
  - Jake Awe (https://github.com/AyodeAwe)

URL: #1389
  • Loading branch information
jameslamb authored May 30, 2024
1 parent 3414c78 commit a81f016
Show file tree
Hide file tree
Showing 5 changed files with 0 additions and 5 deletions.
1 change: 0 additions & 1 deletion conda/recipes/cuproj/meta.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,6 @@ requirements:
- python
- rmm ={{ minor_version }}
- scikit-build-core >=0.7.0
- setuptools
- proj
- sqlite
run:
Expand Down
1 change: 0 additions & 1 deletion conda/recipes/cuspatial/meta.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,6 @@ requirements:
- python
- rmm ={{ minor_version }}
- scikit-build-core >=0.7.0
- setuptools
run:
{% if cuda_major == "11" %}
- cudatoolkit
Expand Down
1 change: 0 additions & 1 deletion dependencies.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,6 @@ dependencies:
- output_types: [requirements, pyproject]
packages:
- wheel
- setuptools
cuda_version:
specific:
- output_types: conda
Expand Down
1 change: 0 additions & 1 deletion python/cuproj/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ requires = [
"ninja",
"rmm==24.8.*",
"scikit-build-core[pyproject]>=0.7.0",
"setuptools",
"wheel",
] # This list was generated by `rapids-dependency-file-generator`. To make changes, edit ../../dependencies.yaml and run `rapids-dependency-file-generator`.

Expand Down
1 change: 0 additions & 1 deletion python/cuspatial/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ requires = [
"ninja",
"rmm==24.8.*",
"scikit-build-core[pyproject]>=0.7.0",
"setuptools",
"wheel",
] # This list was generated by `rapids-dependency-file-generator`. To make changes, edit ../../dependencies.yaml and run `rapids-dependency-file-generator`.

Expand Down

0 comments on commit a81f016

Please sign in to comment.