remove unnecessary 'setuptools' dependency #5901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameslamb
added
2 - In Progress
github-actions
bot
added
conda
This was referenced May 21, 2024
jameslamb
changed the title
dantegd
approved these changes
May 22, 2024
|
@jameslamb is this PR ready to get out of draft? |
|
Sure! I was waiting to ask for reviews until I saw CI (hopefully) passing. Looks like the I strongly suspect those are not related to my changes, but I'm not sure. |
|
@jameslamb those jobs are not blocking and those failures are known/expected currently (there are a few PRs with fixes in flight). |
|
Oh ok great! Then yes I think this is ready. |
dantegd
approved these changes
May 22, 2024
AyodeAwe
approved these changes
May 24, 2024
|
admin merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to rapidsai/build-planning#62.
It looks like this project has an unnecessary dependency on
setuptools. I suspect that's left over from before the project was cut over toscikit-build-core.Notes for Reviewers
There are no uses of
setuptoolshere:Also note that I'm intentionally targeting
branch-24.08, to avoid making this change onbranch-24.06so close to a release.