manifest readiness update for odh-operator v2

[VedantMahabaleshwarkar]

Description

• copied over the latest odh-model-controller manifests from odh-manifests/odh-model-controller and put them in config/
• created overlays/odh and overlays/dev to handle the ODH overlays and also have an overlay option for local development
• removed the need to have 2 copies of odh-model-controller manifests for kserve and modelmesh
• • this is done by removing the need to have a kserve-enabled flag, thus the same set of manifests can be used by both serving stacks

Testing

Follow testing instructions on opendatahub-io/modelmesh-serving#237

Merge criteria:

• The commits are squashed in a cohesive manner and have meaningful messages.
• Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has manually tested the changes and verified that the changes work

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[VedantMahabaleshwarkar]

/retest

[heyselbi]

Tested using instructions with Vedant's images in operator and in odh-model-controller:

• modelmesh: passed
• kserve: passed

[heyselbi]

/lgtm

[VedantMahabaleshwarkar]

/retest

[heyselbi]

/lgtm

[israel-hdez]

I'm seeing two main differences, when comparing to odh-manifests:

• Here, there is a new kserve-prometheus-k8s ClusterRole. Is it correct to be creating this resources?
• In this PR, there is no ServiceMonitor. Is it OK to omit this resource?
• $(monitoring-namespace) variable is not being replaced correctly.

[VedantMahabaleshwarkar]

@israel-hdez

Here, there is a new kserve-prometheus-k8s ClusterRole. Is it correct to be creating this resources?

This clusterrole was created for kserve, it was added in the kserve copy of odh-model-controller manifests, you can find it here

In this PR, there is no ServiceMonitor. Is it OK to omit this resource?

ServiceMonitor was already in config/prometheus/monitor.yaml so did not need to add it in this PR again

$(monitoring-namespace) variable is not being replaced correctly

will take a look

[israel-hdez]

ServiceMonitor was already in config/prometheus/monitor.yaml so did not need to add it in this PR again

I was meaning that it is missing in the resulting manifests, not that is missing in the code.

[VedantMahabaleshwarkar]

I was meaning that it is missing in the resulting manifests, not that is missing in the code.

@israel-hdez I see the servicemonitor being generated when I run kustomize build . in config/base. You can see it in the generated output here

[israel-hdez]

@israel-hdez I see the servicemonitor being generated when I run kustomize build . in config/base. You can see it in the generated output here

OK, so config/base is the entrypoint. I was using another entrypoint.

With this, I'm seeing only 2 issues:

• $(monitoring-namespace) variable is not being replaced correctly (which I mentioned earlier)
• A ClusterRoleBinding has a diffferent name:
  • odh-manifests: odh-model-controller-rolebinding-opendatahub
  • here: odh-model-controller-rolebinding (i.e. no suffix)

[VedantMahabaleshwarkar]

@israel-hdez

$(monitoring-namespace) variable is not being replaced correctly (which I mentioned earlier)
A ClusterRoleBinding has a diffferent name:
odh-manifests: odh-model-controller-rolebinding-opendatahub
here: odh-model-controller-rolebinding (i.e. no suffix)

Should be fixed now

[openshift-ci]

@VedantMahabaleshwarkar: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/fvt	0c6c385	link	true	/test fvt

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[Jooho]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: heyselbi, Jooho, VedantMahabaleshwarkar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Jooho,VedantMahabaleshwarkar,heyselbi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Jooho]

I will merge this manually because we need to update openshift-ci with this issue

[Jooho]

image is manually updated too.

• quay.io/opendatahub/odh-model-controller:fast-0c6c385
• quay.io/opendatahub/odh-model-controller:fast