address PR comments

Signed-off-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com>
opendatahub-io · Oct 17, 2023 · 89e5561 · 89e5561
1 parent 33df4b8
commit 89e5561
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 8 deletions.
diff --git a/config/base/kustomization.yaml b/config/base/kustomization.yaml
@@ -13,13 +13,6 @@ generatorOptions:
   disableNameSuffixHash: true
 
 vars:
-  - fieldref:
-      fieldPath: metadata.namespace
-    name: mesh-namespace
-    objref:
-      apiVersion: v1
-      kind: ConfigMap
-      name: odh-model-controller-parameters
   - fieldref:
       fieldPath: data.odh-model-controller
     name: odh-model-controller

diff --git a/config/overlays/odh/odh_model_controller_manager_patch.yaml b/config/overlays/odh/odh_model_controller_manager_patch.yaml
@@ -14,5 +14,5 @@ spec:
           image: $(odh-model-controller) 
           env:
             - name: MONITORING_NS
-              value: kserve
+              value: $(monitoring-namespace)
           name: manager
diff --git a/config/rbac/role.yaml b/config/rbac/role.yaml
@@ -214,3 +214,19 @@ rules:
   - patch
   - update
   - watch
+- apiGroups:
+    - extensions
+  resources:
+    - ingresses
+  verbs:
+    - get
+    - list
+    - watch
+- apiGroups:
+    - networking.k8s.io
+  resources:
+    - ingresses
+  verbs:
+    - get
+    - list
+    - watch