Skip to content

Commit

Permalink
fix variable substitution
Browse files Browse the repository at this point in the history
Signed-off-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com>
  • Loading branch information
VedantMahabaleshwarkar committed Oct 18, 2023
1 parent 89e5561 commit 0c6c385
Show file tree
Hide file tree
Showing 4 changed files with 17 additions and 2 deletions.
14 changes: 14 additions & 0 deletions config/base/kustomization.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,20 @@ generatorOptions:
disableNameSuffixHash: true

vars:
- fieldref:
fieldPath: metadata.namespace
name: mesh-namespace
objref:
apiVersion: v1
kind: ConfigMap
name: odh-model-controller-parameters
- fieldref:
fieldPath: data.monitoring-namespace
name: monitoring-namespace
objref:
apiVersion: v1
kind: ConfigMap
name: odh-model-controller-parameters
- fieldref:
fieldPath: data.odh-model-controller
name: odh-model-controller
Expand Down
1 change: 1 addition & 0 deletions config/base/params.env
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
monitoring-namespace=opendatahub
odh-model-controller=quay.io/opendatahub/odh-model-controller:fast
2 changes: 1 addition & 1 deletion config/overlays/odh/params.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
varReference:
- path: metadata/name
kind: ClusterRoleBinding
apiGroup: authorization.openshift.io
apiGroup: rbac.authorization.k8s.io/v1
- path: spec/template/spec/containers[]/image
kind: Deployment
apiVersion: apps/v1
2 changes: 1 addition & 1 deletion config/rbac/role_binding.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRoleBinding
metadata:
name: odh-model-controller-rolebinding
name: odh-model-controller-rolebinding-$(mesh-namespace)
roleRef:
apiGroup: rbac.authorization.k8s.io
kind: ClusterRole
Expand Down

0 comments on commit 0c6c385

Please sign in to comment.