Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move model-mesh to opendatahub/manifests #221

Conversation

VedantMahabaleshwarkar
Copy link

@VedantMahabaleshwarkar VedantMahabaleshwarkar commented Sep 28, 2023

Description

  • copied over the latest model-mesh manifests from odh-manifests/model-mesh/odh-modelmesh-controller and put them in opendatahub/manifests along with nessary changes to work with the new directory structure
  • separated out modelmesh manifests from odh-model-controller manifests to enable the opendatahub-operator fetching manifests from each individual repo

Testing

The testing for this PR is to be done along with the testing for this and this PR since they target the same set of overall changes.
The ODH operator image has been built with the following changes :

How Has This Been Tested?

ModelMesh testing

  • cluster login
  • git clone git@github.com:VedantMahabaleshwarkar/opendatahub-operator.git
  • cd opendatahub-operator
  • switch to branch manifests_transition_mlserving
  • make deploy -e IMG=quay.io/vedantm/opendatahub-operator:latest
  • This will install the ODH operator in NS opendatahub-operator-system with the image quay.io/vedantm/opendatahub-operator:latest
  • create the following DSC in NS opendatahub
apiVersion: datasciencecluster.opendatahub.io/v1
kind: DataScienceCluster
metadata:
  name: example
spec:
  components:
    modelmeshserving:
      managementState: Managed
  • deploy and test a model with modelmesh

Kserve testing

Note: Cleanup kserve CRDs before testing modelmesh
  • cluster login
  • install ODH Kserve + dependencies stack by following instructions
Note: Only install the dependencies, the ODH operator will be a custom install according to next steps
  • git clone git@github.com:VedantMahabaleshwarkar/opendatahub-operator.git
  • cd opendatahub-operator
  • switch to branch manifests_transition_mlserving
  • make deploy -e IMG=quay.io/vedantm/opendatahub-operator:latest
  • This will install the ODH operator in NS opendatahub-operator-system with the image quay.io/vedantm/opendatahub-operator:latest
  • create the following DSC in NS opendatahub
apiVersion: datasciencecluster.opendatahub.io/v1
kind: DataScienceCluster
metadata:
  name: default
spec:
  components:
    kserve:
      managementState: Managed

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@openshift-ci
Copy link

openshift-ci bot commented Sep 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: VedantMahabaleshwarkar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [VedantMahabaleshwarkar]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com>
Signed-off-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com>
Signed-off-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com>
Signed-off-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com>
@vaibhavjainwiz
Copy link
Member

@VedantMahabaleshwarkar Rather them maintaining manifest in opendatahub/manifests folder could we simply maintain them inside /config folder itself so that it would be more allign with the way we are maintaing manifest for odh-model-controller and kserve.

@VedantMahabaleshwarkar
Copy link
Author

replaced by #237

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants