add manifests for odh-model-controller and model-mesh

[VedantMahabaleshwarkar]

Description

• Added model-mesh and odh-model-controller manifests to get_all_manifests.sh
• added logic to allow kserve and model-mesh to share a singular odh-model-controller deployment

Testing

The testing for this PR is to be done along with the testing for this and this PR since they target the same set of overall changes.
The ODH operator image has been built with the following changes :

• odh-model-controller manifests are pre built from https://github.com/opendatahub-io/odh-model-controller/tree/remove_kserve_flag which has equivalent changes to this repo, except that it deploys the image quay.io/vedantm/odh-model-controller:remove-kserve-flag which contains the changes for this PR.
• model-mesh manifests are pre built from https://github.com/opendatahub-io/modelmesh-serving/tree/manifests_transition_v2 and the manfest location is opendatahub/manifests. These manifests are now no longer bundled with odh-model-controller manifests
• opendatahub-operator reconciliation for kserve and modelmesh allow a common deployment of odh-model-controller

How Has This Been Tested?

ModelMesh testing

• cluster login
• git clone git@github.com:VedantMahabaleshwarkar/opendatahub-operator.git
• cd opendatahub-operator
• switch to branch transition
• make deploy -e IMG=quay.io/vedantm/opendatahub-operator:version_builtin
• This will install the ODH operator in NS opendatahub-operator-system with the image quay.io/vedantm/opendatahub-operator:version_builtin
• create the following DSC in NS opendatahub

apiVersion: datasciencecluster.opendatahub.io/v1
kind: DataScienceCluster
metadata:
  name: example
spec:
  components:
    modelmeshserving:
      managementState: Managed

• deploy and test a model with modelmesh

Kserve testing

Note: Cleanup kserve CRDs before testing modelmesh

• cluster login
• install ODH Kserve + dependencies stack by following instructions

Note: Only install the dependencies, the ODH operator will be a custom install according to next steps

• git clone git@github.com:VedantMahabaleshwarkar/opendatahub-operator.git
• cd opendatahub-operator
• switch to branch transition
• make deploy -e IMG=quay.io/vedantm/opendatahub-operator:version_builtin
• This will install the ODH operator in NS opendatahub-operator-system with the image quay.io/vedantm/opendatahub-operator:version_builtin
• create the following DSC in NS opendatahub

apiVersion: datasciencecluster.opendatahub.io/v1
kind: DataScienceCluster
metadata:
  name: default
spec:
  components:
    kserve:
      managementState: Managed

• deploy and test a kserve model using instructions

Merge criteria:

• The commits are squashed in a cohesive manner and have meaningful messages.
• Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has manually tested the changes and verified that the changes work

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[VedantMahabaleshwarkar]

Custom ODH operator image was built with the following settings in get_all_manifests.sh for the operator :

["odh-model-controller"]="VedantMahabaleshwarkar:odh-model-controller:manifests_transition_test:config:odh-model-controller"
["model-mesh"]="VedantMahabaleshwarkar:modelmesh-serving:manifests_overlay:config:model-mesh"

[VaishnaviHire]

@VedantMahabaleshwarkar Can you also fix the linter issues?

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: VaishnaviHire

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [VaishnaviHire]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[VaishnaviHire]

/lgtm

[openshift-ci]

@VedantMahabaleshwarkar: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/opendatahub-operator-e2e	6d33c15	link	true	/test opendatahub-operator-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[VaishnaviHire]

/test opendatahub-operator-e2e

[VaishnaviHire]

Tests successful locally

/lgtm