Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge kserve and modelmesh deployment modes for odh-model-controller #87

Closed
Tracked by #207
VedantMahabaleshwarkar opened this issue Sep 20, 2023 · 0 comments · Fixed by #92
Closed
Tracked by #207

Merge kserve and modelmesh deployment modes for odh-model-controller #87

VedantMahabaleshwarkar opened this issue Sep 20, 2023 · 0 comments · Fixed by #92
Assignees
@VedantMahabaleshwarkar
Labels
rhods-2.4

Comments

@VedantMahabaleshwarkar
Copy link
Contributor

Currently odh-model-controller is being deployed with the kserve-enabled=true flag for kserve reconciliation logic and kserve-enabled=false for modelmesh.
These flags are hardcoded in the manifests. This was done as it was not possible to deploy both kserve and modelmesh together previously. As this restriction no longer applies, we do not need the kserve-enabled flag anymore, and odh-model-controller will not need separate manifests for both components.

This is needed as ODH operator v2 is going to be pulling manifests directly from the component repo.
Closed
1 task
@heyselbi heyselbi moved this to To-do/Groomed in ODH Model Serving Planning Sep 21, 2023
@heyselbi heyselbi moved this from To-do/Groomed to In Progress in ODH Model Serving Planning Sep 27, 2023
This was linked to pull requests Oct 10, 2023
manifest readiness update for odh-operator v2 #92
Merged
Manifests transition stable #93
Closed
@VedantMahabaleshwarkar VedantMahabaleshwarkar moved this from In Progress to Under Review in ODH Model Serving Planning Oct 11, 2023
@Jooho Jooho closed this as completed in #92 Oct 19, 2023
@github-project-automation github-project-automation bot moved this from Under Review to Done in ODH Model Serving Planning Oct 19, 2023
@bdattoma bdattoma mentioned this issue Nov 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VedantMahabaleshwarkar VedantMahabaleshwarkar

Labels
rhods-2.4
Projects
Internal tracking
Status: Done
ODH Feature Tracking
Status: No status
ODH Model Serving Planning
Status: Done
Milestone
No milestone
2 participants
@VedantMahabaleshwarkar @heyselbi