v6.12.1 proposal #17180
Merged
v6.12.1 proposal #17180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provide shortcut `node::CheckedMalloc()` and friends that replace `node::Malloc()` + `CHECK_NE(·, nullptr);` combinations in a few places. Backport-PR-URL: #16587 PR-URL: #8482 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Call `v8::Isolate::GetCurrent()->LowMemoryNotification()` when an allocation fails to give V8 a chance to clean up and return memory before retrying (and possibly giving up). Backport-PR-URL: #16587 PR-URL: #8482 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
This commit removes the small node-tap lookalike from several of the streams2 tests. It's only used by six tests, and is inconsistent with all other tests. Backport-PR-URL: #17024 PR-URL: #13707 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
nodejs-github-bot
added
build
MylesBorins
force-pushed
the
v6.12.1-proposal
branch
from
03a5153
to
100d9ae
Compare
MylesBorins
added a commit
that referenced
this pull request
Nov 21, 2017
Notable Changes: Coming Soon PR-URL: #17180
|
Looks like we have a legit failure for coffee-script 😢 |
MylesBorins
force-pushed
the
v6.12.1-proposal
branch
from
100d9ae
to
5f9b3d6
Compare
MylesBorins
added a commit
that referenced
this pull request
Nov 21, 2017
Notable Changes: Coming Soon PR-URL: #17180
|
I've backed out the commit breaking coffeescript, it was a backport explicitly to v6.x CI: https://ci.nodejs.org/job/node-test-pull-request/11604/ |
What PR/commit was it? |
`crypto.createCipher()` sets the fixed IV derived from password and it leads to a security risk of nonce reuse when counter mode is used. A warning is emitted when CTR, GCM or CCM is used in `crypto.createCipher()` to notify users to avoid nonce reuse. Backport-PR-URL: #16583 Fixes: #13801 PR-URL: #13821 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
EVP_CIPHER_CTX_FLAG_WRAP_ALLOW flag needs to be set in using wrap mode ciphers. In `crypto.createCipher()`, AES key wrap mode does not use a default IV defined in RFC3394 but a generated IV with `EVP_BytesToKey()` to be consistent API behaviors with other ciphers. The built-in AES wrap mode in OpenSSL is not supported in FIPS mode as http://openssl.6102.n7.nabble.com/AES-Key-Wrap-in-FIPS-Mode-td50238.html so its tests in FIPS mode are skipped. Backport-PR-URL: #16584 Fixes: #15009 PR-URL: #15037 Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
This exception can logically never happen because of the key stretching that takes place first. Failure must therefore be a bug in Node.js and not in the executing script. Backport-PR-URL: #16585 PR-URL: #15183 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
V8 options allow either '_' or '-' to be used in options as a seperator, such as "--abort-on_uncaught-exception". Allow these case variations when used with NODE_OPTIONS. PR-URL: #14093 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #15399 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This commit ensures that spawn()'s shell option is unconditionally set to false when fork() is called. Refs: #15299 Fixes: #13983 PR-URL: #15352 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #15621 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #15609 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
PR-URL: #15913 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This was a task from Code & Learn at NINA17. PR-URL: #15824 Reviewed-By: Ryan Graham <r.m.graham@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
PR-URL: #15837 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
PR-URL: #16016 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Refael Ackermann <refack@gmail.com>
PR-URL: #16916 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
PR-URL: #16919 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
PR-URL: #16912 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
PR-URL: #16929 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Include value that cause failure in error message in test-cluster-master-kill.js. PR-URL: #16826 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Replace `common.fixturesDir` with `fixtures.path()` usage in test/pummel/test-hash-seed.js. PR-URL: #16823 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Based on feedback during a recent collaborator onboarding, move the metadata description closer to where the instructions for editing a commit message are. Indicate which metadata are required and which are optional. Make the punctuation more consistent. Previously, sentences prior to instructions ended in a period, a colon, or no punctuation at all. Colon seems best, so changed the Technical How-To section to use colons. PR-URL: #15710 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Benedikt Meurer <benedikt.meurer@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
PR-URL: #16833 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
In test-fs-realpath-on-substed-drive, require common/fixtures module and swapped the location of fixturesDir from common to fixtures module. PR-URL: #16813 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
PR-URL: #16978 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* remove comment that isn't relevant/important * add comment that explains what the test does PR-URL: #16829 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #16936 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
The `dev_t` is unsigned on Linux, use Integer::NewFromUnsigned to fix cast overflow PR-URL: #16705 Fixes: #16496 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
PR-URL: #16705 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
This commit excludes src\tracing\trace_event.h and src\tracing\trace_event_common.h from the linter but allows the rest of the files in src\tracing to be examined by the linter which is similar to what the Makefile does. Refs: #16720 Backport-PR-URL: #17172 PR-URL: #16720 Reviewed-By: James M Snell <jasnell@gmail.com>
Original commit message:
[turbofan] Fix missing lazy deopt in object literals.
This adds a missing lazy bailout point when defining data properties
with computed property names in object literals. The runtime call to
Runtime::kDefineDataPropertyInLiteral can trigger deopts. The necessary
bailout ID already exists and is now properly used.
R=jarin@chromium.org
TEST=mjsunit/regress/regress-crbug-621816
BUG=chromium:621816
Review-Url: https://codereview.chromium.org/2099133003
Cr-Commit-Position: refs/heads/master@{#37294}
Refs: v8/v8@4af8029
PR-URL: #17290
Fixes: #14326
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
cctest has `so.59` extension when building node shared library in linux. The appending is defined in node.gypi and the cctest target in node.gyp includes node.gypi. Moving the appending from node.gypi to node target in node.gyp fixes the issue. Signed-off-by: Yihong Wang <yh.wang@ibm.com> Backport-PR-URL: #17255 PR-URL: #16680 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
MylesBorins
force-pushed
the
v6.12.1-proposal
branch
from
5f9b3d6
to
4a99c2b
Compare
|
One more bump @nodejs/release ptal at the notable changes CI: https://ci.nodejs.org/job/node-test-pull-request/11772/ |
cjihrig
approved these changes
Nov 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2017-12-05, Version 6.12.1 'Boron' (LTS), @MylesBorins
This LTS release comes with 263 commits. This includes 173 which are test related,
41 which are doc related, 18 which are build / tool related and 1 commit which is an update to a dependency.
Notable Changes
Commits
575a920a16] - assert: fix actual and expected order (Steve Jenkins) #15866a0c1d10e91] - build: remove cctest extension (Yihong Wang) #16680c287f1235c] - build: include src\tracing when linting on win (Daniel Bevenius) #16720706812bc2f] - build: skip bin override on windows (Hitesh Kanwathirtha) #16460f4627603aa] - build: fix npm install with --shared (Ben Noordhuis) #164386d63612e93] - build: correct minor typo in lttng help message (Daniel Bevenius) #16101de82db7f85] - build: ignore empty folders in test-addons (Gregor) #16031ac1beb0fb0] - build: use bin override if nopythonin PATH (Bradley T. Hughes) #16241d4b3b633d8] - build: allow build with system python 3 (Emily Marigold Klassen) #16058fc2ab06014] - build, windows: use /bigobj for debug builds (Nikolai Vavilov) #16289ccca11d026] - build,win: set /MP separately in Debug and Release (Nikolai Vavilov) #16415a14f564686] - build,win: use /MP for debug builds (Nikolai Vavilov) #163338813867577] - child_process: set shell to false in fork() (Alex Gresnel) #15352f2cafff9b0] - crypto: fix error of createCipher in wrap mode (Shigeki Ohtsu) #150377115079c4f] - crypto: warn if counter mode used in createCipher (Shigeki Ohtsu) #1382150c3dabc0f] - deps: backport 4af8029 from upstream V8 (Michaël Zasso) #17290101eb981fe] - doc: mention constant-time in crypto doc (Mithun Sasidharan) #166041bc5c3836c] - doc: recommend node-core-utils for metadata (Rich Trott) #169784583f1be0c] - doc: reorganize COLLABORATOR_GUIDE.md (Rich Trott) #15710fce790285f] - doc: improve documentation for the vm module (Franziska Hinkelmann) #16867727a0fe641] - doc: update subprocess.killed (cjihrig) #1674844c0385b04] - doc: more accurate zlib windowBits information (Anna Henningsen) #16511732af9b8a4] - doc: add Gibson Fahnestock to Release team (Gibson Fahnestock) #16620935b15285f] - doc: slightly relax 50 character rule (James M Snell) #1652339c63da6d2] - doc: add note to releases.md (Jon Moss) #1650760ae428f30] - doc: add dot in documentations (erwinwahyura) #165427ae23b744b] - doc: fix missing newline character (Daijiro Wachi) #16447af869f03c1] - doc: add recommendations for first timers (Refael Ackermann) #16350b7d609c2f8] - doc: replace undocumented encoding aliases (Vse Mozhet Byt) #163682cbf75da7e] - doc: replace methods used in the example code (Damian) #164160b5a0ada2a] - doc: fix comment in assert.md (umatoma) #163354fbc490704] - doc: add space after period (Diego Rodríguez Baquero) #16334c3cc0fd258] - doc: minor correction to note on process section (Daniel Bevenius) #1631147bf494979] - doc: add apapirovski to collaborators (Anatoli Papirovski) #163029c96d7f4fd] - doc: clarify os.cpus() returns logical CPU cores (Luke Childs) #16282ba62b0e48a] - doc: support multidimensional arrays in type link (Vse Mozhet Byt) #16207aefaed40f0] - doc: move Shigeki to TSC Emeritus (Rich Trott) #161951fdcf75f9c] - doc: Update a typo in module.js' comments (Orta) #16205799c6fdc1c] - doc: add missing comma (Jon Moss) #162048c070f9ed5] - doc: added note to fs.watchFile on previousStat (NiveditN) #160992515cad90e] - doc: ensure collaborators validate commits (Bradley Farias) #161627647d41da1] - doc: move 8 collaborators to emeriti (Rich Trott) #16173de8155ebf2] - doc: include V8 commit URL in V8 backport guide (Gibson Fahnestock) #160546f1ba792d7] - doc: add pronoun for fhinkel (F. Hinkelmann) #160698da3b51472] - doc: document windows shell support (Tim Ermilov) #16104281023b20d] - doc: exempt test/doc only changes from 48-hr rule (Anna Henningsen) #1613504d5835722] - doc: rename good first contrib label (Jeremiah Senkpiel) #161501064258f9d] - doc: remove bold typography from STYLE_GUIDE.md (Rich Trott) #1608523e9bba9c8] - doc: ctc -> tsc in onboarding extras (Bryan English) #15621ff66d63642] - doc: fix emitKeypressEvents stream type (Oblosys) #153991bd6962842] - doc: make stream.Readable consistent (Sakthipriyan Vairamani (thefourtheye)) #167866b9bd51021] - doc: correct effects to affects (gowpen) #167946af9311939] - doc: correct EventEmitter reference (gowpen) #167911a633e3cd8] - doc: add docs for Zlib#close() (Luigi Pinca) #16592290df5ac41] - doc: add details about rss on process.memoryUsage (Anthony Nandaa) #165663e6da45ce0] - doc: howto decode buffers extending from Writable (dicearr) #16403c64ed977fc] - doc, win: remove note about resize (Bartosz Sosnowski) #16320644989cf6a] - fs: use Number::New since all fields are uint64_t (Huáng Jùnliàng) #16705925e58fecb] - fs: fix stat dev unsigned cast overflow (Huáng Jùnliàng) #1670592b13e455f] - https: Use secureProtocol in Agent#getName (Andreas Lind) #9452b0ac76d145] - meta: add note about email sync to CONTRIBUTING.md (Vse Mozhet Byt) #16340bf7f63d51b] - net: change assert to conform to other files (James Hodgskiss) #15861ae3ad5502b] - src: remove unused includes from node_wrap.h (Daniel Bevenius) #16179a368e5fa63] - src: make StreamBase prototype accessors robust (Joyee Cheung) #16860c79dd9e3ce] - src: CHECK() for argument overflow in Spawn() (cjihrig) #167617c69ca58e0] - src: move handle properties to prototype (Ben Noordhuis) #16482c87a620ed8] - src: remove superfluous HandleScope (Ben Noordhuis) #164822f5edc6fd5] - src: remove unused include in tty_wrap.h (Daniel Bevenius) #1637942cb64ee91] - src: fix etw provider include on Windows (Joyee Cheung) #16639b00ced5b52] - src: do not include x.h if x-inl.h is included (Joyee Cheung) #16548a4688b0c43] - src: make header file self-contained (Joyee Cheung) #16518cf80089477] - src: node_dtrace line continuations clean up (Daniel Bevenius) #157774639cfff0a] - src: rename perfctr_macros.py->noperfctr_macros.py (Daniel Bevenius) #1610070f574e6ff] - src: add help for NODE_PENDING_DEPRECATION env (Thomas Corbière) #1560975b1e30e6b] - src: add --pending-deprecation to NODE_OPTIONS (Thomas Corbière) #15494f659e49862] - src: whitelist v8 options with '_' or '-' (Sam Roberts) #1409379171e0c2f] - src: turn key length exception into CHECK (Ben Noordhuis) #15183e18df46092] - src: notify V8 for low memory when alloc fails (Anna Henningsen) #84826a0eb9f6cf] - src: provide allocation + nullptr check shortcuts (Anna Henningsen) #84824aec8cfcd2] - src: pass desired return type to allocators (Anna Henningsen) #848219f3ac9749] - src: add Malloc() size param + overflow detection (Anna Henningsen) #84826269ba334d] - test: allow tests to pass without internet (Daniel Bevenius) #16255f0eeddb4b8] - test: reuse existing PassThrough implementation (Tobias Nießen) #169364752fc4336] - test: refactor comments in test-child-process-spawnsync-maxbuf (ChrBergert) #16829f226ca6b12] - test: used fixturesDir from fixtures modules (Klemen Kogovsek) #168135e2231e407] - test: add a test description (Grant Gasparyan) #16833a8cff7ad4a] - test: use common/fixtures module in hash-seed test (Javier Blanco) #16823090cc9713e] - test: improve template value for test message (Stephan Smith) #168261d3793eb77] - test: change concatenated string to template (Deepthi Sebastian) #1692979dfc3f475] - test: change concatenated string to template (Anawesha Khuntia) #169122232231d4f] - test: change string concatenation to template (Suryanarayana Murthy N) #16919674cbf8402] - test: replace string concatenation with template (Kabir Islam) #16916969defaae9] - test: enable mustCall() during child exit (Vipin Menon) #169159d4abaa243] - test: replace string concatenation with template (Tanvi Kini) #169132a1ebae567] - test: cover vm.runInNewContext() (cjihrig) #169062043ce39d5] - test: improve assertion messages (Neil Vass) #16885668644008e] - test: improve assert messages in stream test (Katie Stockton Roberts) #16884714eb0bc7c] - test: improve assertion in test-require-dot (Adam Wegrzynek) #168058e5b4f543c] - test: add values to error message (Adam Jeffery) #16831b3b7858a97] - test: replace common.fixtiresDir with fixtures.readKey() (woj) #168173acf156b68] - test: remove message argument in cluster setup test (mbornath) #16838cedf8a1cb2] - test: move test-http-keepalive-maxsockets to sequential (Rich Trott) #16777ffbb4e68e8] - test: use default assertion message (jonask) #16819dd558a56af] - test: include file mode in assert message (Sascha Tandel) #168153d8b3f7b4a] - test: refactor tls test to use fixtres.readSync (Brian O'Connell) #1681654d4557199] - test: use fixtures module in test-repl (Maring, Damian Lion) #168099f9e824fc5] - test: update test to use fixtures.readKey (Dara Hayes) #16811a99755f3fd] - test: fix typos in read-buffer tests (Jimi van der Woning) #16834e7a456a5ee] - test: replace common.fixturesDir with fixtures module (Dumitru Glavan) #1680304af0fdab7] - test: replace common.fixturesDir with fixtures.readSync() (Adri Van Houdt) #16802755f5e3fd1] - test: update test to use fixtures (Adam Wegrzynek) #16799143d8a1b3d] - test: fix typo (Oscar Funes) #1593884741fdc81] - test: update test-timers-block-eventloop.js (zhangzifa) #163148e62fcb2cf] - test: replace fixturesDir in test-tls-connect (Casie Lynch) #15849d6dc579f3c] - test: use fixtures module (Iryna Yaremtso) #1590110c24a157c] - test: add details in assertions in test-vm-context (Vladimir Ilic) #16116cb1d16d26b] - test: increase fs.exists coverage (Nigel Kibodeaux) #15963d3981ae552] - test: use fixtures module in test-fs-realpath.js (Raphael Rheault) #15904532c9606b3] - test: use fixtures module (Scott J Beck) #1584358fe9b4ec3] - test: imporove assert messages (Hadis-Fard) #1602191f9779794] - test: show values instead of assertion message (Cheyenne Arrowsmith) #159790ace5a158d] - test: include values in assertion messages (nhoel) #159968663b05711] - test: use process.features.debug in common module (Rich Trott) #165371fffa165a1] - test: use common.buildType in repl-domain-abort (Rich Trott) #165387d93da54bb] - test: skip test-process-config if no config.gypi (Gibson Fahnestock) #164365c20164354] - test: use fixtures module in tls-handshake-error (Mark Walker) #159394f04d15aa3] - test: add failing vm tests to known_issues (Michaël Zasso) #164102b1042bb29] - test: allow for different nsswitch.conf settings (Daniel Bevenius) #163785095b991c0] - test: handle blank shells in test-os.js (Gibson Fahnestock) #1628762dd6a2c40] - test: increase enoughTestMem to 1.75 Gb (Rich Trott) #163749c229b4bd3] - test: use fixtures.readKey in https-timeout-server (Nicolas 'Pixel' Noble) #15871773652903d] - test: use fixtures.readKey instead of fixturesDir (Paul Marion Camantigue) #1597634dfce7710] - test: replace fixturesDir with fixtures module (tpurcell) #162620a88e1bd60] - test: replace fixturesDir with fixtures module (André Føyn Berge) #159479e74e542a2] - test: skip test due to file size limit (jBarz) #16273e070e592dd] - test: remove error msg in test-vm-symbols.js (Daniel Abrão) #15873257ece287c] - test: remove error messages in test-buffer-alloc (Braden Whitten) #1586732fa91519a] - test: update assert error messages (Omar Gonzalez) #16035da85e6c552] - test: expand error message (Stefania Sharp) #15991cbbe125f71] - test: use fixtures module (Kanika Shah) #159596f15b011c0] - test: remove literal messages (Oscar Funes) #15938aa269ad59b] - test: fix stderr reference (Oscar Funes) #159383f35fc063e] - test: use fixtures module in test-https-truncate (Gene Wu) #15875c58eaaf1a8] - test: use fixtures module (Alvaro Cruz) #1587448e1320c44] - test: use fixtures module (Lance Barlaan) #15872339bdca558] - test: use default message for assert.strictEqual (hwaisiu) #15970ab580c3ae2] - test: improve assert message in internet test (Nikki St Onge) #159986285e7221e] - test: replace common.fixturesDir (Shawn McGinty) #15834fa8315cb68] - test: refactor test-process-kill-null (Luigi Pinca) #16236c26abc8e94] - test: add missing spaces in concatenations (Vse Mozhet Byt) #16244a94a75f69a] - test: update output to include exit code & signal (Jenna Zeigen) #159458eb84d6780] - test: change common.fixturesDir to fixtures.path (tejbirsingh) #15860806f03e54c] - test: split up and refactor test-domain (Anna Henningsen) #13614e5fbc03563] - test: replace fixturesDir with common.fixtures (Kasim Doctor) #158102ab826c497] - test: replaced fs.readSync with fixtures.readSync (Lam Chan) #158821fe3e866cf] - test: improve coverage for process.umask (Evan Lucas) #161880689ea66ed] - test: remove message from notStrictEqual (twk-b) #16048fafbbb6347] - test: use fixtures module (Ben Hallion) #15808f2108fa51d] - test: use ES6 classes instead of util.inherits (Tobias Nießen) #16938eb11a70424] - test: refactor test-cluster-setup-master (Jean-Baptiste Brossard) #16065e00a4c820f] - test: replace fixtureDir with fixtures methods (Vladimir Ilic) #16114f46e1187b3] - test: remove error messages in crypto-binary test (Kim Gentes) #15981086d8519a1] - test: use fixtures module over fixturesDir (JamesNimlos) #1584738179fd1ed] - test: use common.fixtures module (Shaun Sweet) #15992229a1fa299] - test: replace fixturesDir with fixtures.path (Bear Trickey) #15994c10594f70f] - test: update fixturesDir import (Tyler Seabrook) #1588753449f303f] - test: replace fixturesDir with fixtures methods (Komivi Agbakpem) #15967a28d666f0e] - test: replace fixturesDir with the fixtures module (WeiPlanet) #16027d59175090d] - test: change crypto decipheriv assertion messages (Daniel Kostro) #16007541866ea86] - test: replaces fixturesDir with fixtures (Mike Fleming) #1583557ae105c72] - test: remove test messages for assert.strictEqual (Ali Groening) #1599587b9b7c8c4] - test: move to common.fixtures (Justin Beckwith) #1598772f69f3c2c] - test: added fixtures module (Michael Pal) #1598065c5ff8e92] - test: use fixtures in test-tls-multi-key.js (Cheyenne Arrowsmith) #158449eac5aab8c] - test: switch to use common.fixtures.fixturesDir (Roger Jiang) #15814449538851c] - test: use common.fixtures module (Chi-chi Wang) #1601204f3f6dd6a] - test: escape script filename on Windows (Bartosz Sosnowski) #16124501acdf38c] - test: improve assert message in test-dh-regr (Mabry Cervin) #159124c98e07702] - test: fixtures in test-net-pipe-connect-errors (Eric Freiberg) #15922244bfb398d] - test: fixtures in test-process-redirect-warnings-env (Kat Rosario) #1593018479d3cff] - test: fix ordering of strictEqual actual/expected (Chad Zezula) #1600866fd6a1409] - test: use fixtures.readSync (szhang351)6d33564b1a] - test: replaced fixturesDir with common.fixtures (Dolapo Toki) #15836a6f04bec9e] - test: use fixtures.fixturesDir (Gene Wu) #158222103453977] - test: replaces fixturesDir with fixtures methods (Christian Murphy) #15817e705ad2076] - test: fixtures in test-process-redirect-warnings (Nicolas Chaulet) #159179ddbcc877b] - test: update test-crypto-from-binary (Raj Parekh) #160116b8830c1df] - test: use fixtures in test-https-set-timeout-server (Bob Clewell) #1588657590cd097] - test: make use of common/fixtures.fixturesDir (Jem Bezooyen) #15815c9d07faa04] - test: use common/fixtures in test-https-close (Alberto Lopez de Lara) #1587068a2d394dd] - test: use fixtures in test-process-warnings (Suresh Srinivas) #1586928756b318a] - test: use fixtures in tls-friendly-error-message (tobyfarley) #15905a05fe5f716] - test: use common/fixtures in tls-connect-no-host (Donovan Buck) #15986cf31eb7532] - test: use common/fixtures in test-https-agent (jpaulptr) #15941c9c37d076c] - test: use common fixtures module (Kat Rosario) #1585676ab029bea] - test: fs.readFileSync -> fixtures.readKey (Ethan Brown) #16030dabdb2d186] - test: reduce run time for misc benchmark tests (Rich Trott) #161203f56ac4450] - test: improve assertion message in dgram test (Shakeel Mohamed) #1612144a60c3807] - test: use of fixtures in test-pipe-head (Nicolas Chaulet) #15868c4db4e44b8] - test: use fixtures in test-https-localaddress.js (Charles T Wall III) #15811c252d874d7] - test: use common/fixtures in fs-symlink test (AlexeyM) #1583007c14f3054] - test: replace common.fixtures with fixtures module (Jonathan Eskew) #158770f23836e7b] - test: improve assert message (Tri Nguyen) #15909bbdbf8b9b0] - test: replace fixturesDir with fixtures method (suraiyah) #15894c35420d21d] - test: normalize fixtures use (Ruxandra Fediuc) #158553c176fd6f6] - test: replace common.fixturesDir w/common.fixtures (Jason Walton) #1585377f9ef32bd] - test: switch to use common.fixtures module for fixturesDir (r1cebank) #1582171e68799ef] - test: fixturesDir replaced to fixtures module (Pawel Golda) #15809d70f9f6a35] - test: replace common.fixturesDir with fixtures (Stefania Sharp) #160154cf84ea76e] - test: replaces common.fixturesDir usage (Ruy Adorno) #15818788d7db4e9] - test: use common.fixtures.path() (Tobias Kieslich) #16112b7865ea70d] - test: replace common.fixturesDir with fixtures (Shakeel Mohamed) #158579b39ca6cbb] - test: use fixtures module in test (Nigel Kibodeaux) #161175e65069289] - test: use template literals in test-string-decoder (Edward Andrew Robinson) #15884d2b74fe1e3] - test: switch to fixtures module (Christopher Sidebottom) #158801144be09b7] - test: rewrite assert message (Martin Michaelis) #15879095df35a5e] - test: change fixturesDir to fixtures.path (Guilherme Akio Sakae) #158634fd5bf5ff7] - test: replace fixturesDir with common.fixtures (Oliver Luebeck) #15907e3e234ea1c] - test: update http test client function signatures (Jakub Mrowiec - Alkagar) #1580708ca73f52a] - test: replace common.fixturesDir w/ fixtures.path (Druotic) #1581939ae3f1802] - test: replace fixtureDir with fixtures.path (matthewreed26) #159431365a6f597] - test: use common.fixtures module for file path (Adil L) #16017bd8d4401ee] - test: use fixtures module (Maurice Hayward) #16034bba5263d00] - test: replace fixturesDir with fixtures module (tabulatedreams) #16036a8e7fa4e75] - test: replace fixturesDir with fixtures module (Ivan Etchart) #158931fc3851642] - test: change fixturesDir to fixtures.path (Savio Lucena) #15902683e48cb55] - test: changed fixtures require (creisle) #15899f82f691d5e] - test: replaced fixturesDir with fixtures module (Alex McKenzie) #15908e68ef291e7] - test: use common.fixtures in tls test (Ben Michel) #1596571daa68c3d] - test: use fixtures module instead of common (Joe Grace) #15925e81fc8aca7] - test: replaced fixturesDir with fixtures module (Alex McKenzie) #1592733ea6deeab] - test: replace fixturesDir with fixtures module (Greg Matthews) #15932be2b70bb56] - test: replace fixturesDir with fixtures (Mujtaba Al-Tameemi) #1594925a5bf02c7] - test: remove common.fixturesDir (Luis Del Águila) #1595051d87e338e] - test: replace fixturesDir with fixtures module (BinarySo1o) #1596105286b6c80] - test: replaced fixturesDir with common.fixtures (jopann) #15971683c5fa58f] - test: use common.fixtures module in test-preload (Laura Cabrera) #15975000965d427] - test: replaced common.fixturesDir with readKey (Sean Cox) #159330f8b315a9e] - test: replace fixturesDir in tls-env-bad-extra-ca (Annie Weng) #1581348a55d1364] - test: use common.fixtures in checkServerIdentity (Emily Marigold Klassen) #15951909e587a93] - test: replaced common.fixturesDir with readKey (rhalldearn) #15952544cbd7884] - test: replace fixturesDir with fixtures.readKey (Thomas Schorn) #159484005ed619f] - test: replace common.fixturesDir with fixtures. (Sam Skjonsberg) #158028c5b51d9c3] - test: replace fixturesDir with common.fixtures (rachelnicole) #16051107acb1c56] - test: update fixturesDir to fixtures.readKey (bitandbang) #16016643a2c6b19] - test: replace fixturesDir with common.fixtures (Pooya Paridel) #1583714aee78554] - test: update 'fixturesDir' refs in a test file (James M. Greene) #15824e1c45efdbb] - test: use fixtures.readKey in https-agent test (Greg Byram) #159132c6aa17fa9] - test: add test for fork() + shell (cjihrig) #15352148a030345] - test: remove node-tap lookalike (cjihrig) #13707fa5c706bec] - test: refactor exitedAfterDisconnect test (Rich Trott) #167299416dab7ac] - test: use fixtures module in test-https-pfx (Ken Takagi) #158957e9779aade] - test: refactor test-readline-keys (Rich Trott) #112818264328087] - test,net: remove scatological terminology (Rich Trott) #16599bb81390db2] - timers: fix eventloop block (zhangzifa) #15072f3749d7b2c] - tools: remove unneeded parentheses in doc/html.js (Vse Mozhet Byt) #168451c192f50f6] - tools: replace string concatenation with template literals (Kevin Yu) #16804ce007be05b] - tools: replace string concatenation with template literals (Giovanni Lela) #16806d165d3fd1c] - tools: replace string concetation with templates (Patrick Heneise) #16801a8d7f5f52e] - tools: fix cpplint.py when path contains non-ascii (sharkfisher) #16047b48471ac10] - tools: rename unused variale in more pythonic way (Nikhil Komawar) #161715b5b5c0f15] - tools: use template literal in error message (Tim Chon) #15846ae5930bbe4] - tty,doc: add type-check to isatty (Bryan English) #15567