Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: correct EventEmitter reference #16791

Closed
wants to merge 1 commit into from
Closed

doc: correct EventEmitter reference #16791

wants to merge 1 commit into from

Conversation

gowpen
Copy link
Contributor

@gowpen gowpen commented Nov 6, 2017

Corrects an erroneous reference to EventListener meant to be a reference to EventEmitter.

Fixes: #16789

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc events

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. events Issues and PRs related to the events subsystem / EventEmitter. labels Nov 6, 2017
@gowpen
Copy link
Contributor Author

gowpen commented Nov 6, 2017

@benjamingr Thanks for your very fast reply to this issue. Here's a pull request to fix it.

I don't believe new tests are needed so I took that item off the checklist.

Wasn't sure if I should be running the existing tests (perhaps to ensure the change hasn't broken code examples in the docs?). Left it on the list and unchecked to start. If it's necessary please let me know and I'll get set up to do it.

vsemozhetbyt
vsemozhetbyt approved these changes Nov 6, 2017
View reviewed changes
Copy link
Contributor

@vsemozhetbyt vsemozhetbyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

jasnell
jasnell approved these changes Nov 6, 2017
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This should need to wait any longer to land

jasnell pushed a commit that referenced this pull request Nov 6, 2017
@gowpen @jasnell
doc: correct EventEmitter reference
b5f0578 
PR-URL: #16791
Fixes: #16789
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Nov 6, 2017

Landed in b5f0578

@jasnell jasnell closed this Nov 6, 2017
cjihrig pushed a commit to cjihrig/node that referenced this pull request Nov 6, 2017
@gowpen @cjihrig
doc: correct EventEmitter reference
d7df4df 
PR-URL: nodejs#16791
Fixes: nodejs#16789
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@cjihrig cjihrig mentioned this pull request Nov 6, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Nov 14, 2017
@gowpen @MylesBorins
doc: correct EventEmitter reference
6af9311 
PR-URL: #16791
Fixes: #16789
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Nov 21, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Dec 19, 2017
@gowpen @MylesBorins
doc: correct EventEmitter reference
97689c6 
PR-URL: #16791
Fixes: #16789
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
Closed
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
@gowpen @gibfahn
doc: correct EventEmitter reference
24178ac 
PR-URL: #16791
Fixes: #16789
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. events Issues and PRs related to the events subsystem / EventEmitter.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

doc events: Erroneous reference to EventListener
7 participants
@gowpen @jasnell @lpinca @gireeshpunathil @vsemozhetbyt @MylesBorins @nodejs-github-bot