Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meta: add note about email sync to CONTRIBUTING.md #16340

Closed
wants to merge 1 commit into from
Closed

meta: add note about email sync to CONTRIBUTING.md #16340

wants to merge 1 commit into from

Conversation

vsemozhetbyt
Copy link
Contributor

Checklist
Affected core subsystem(s)

doc, meta

Refs: #16339 (comment)

Please, correct my wording if necessary.

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Oct 20, 2017
@vsemozhetbyt vsemozhetbyt mentioned this pull request Oct 20, 2017
Closed
3 tasks
apapirovski
apapirovski approved these changes Oct 20, 2017
View reviewed changes
CONTRIBUTING.md Outdated
@@ -242,6 +242,10 @@ who you are:
$ git config --global user.name "J. Random User"
$ git config --global user.email "j.random.user@example.com"
```
Be sure this local email is also added to your
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/Be/Please make — I think that's a bit nicer but this is a super minor nit.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@vsemozhetbyt vsemozhetbyt added the meta Issues and PRs related to the general management of the project. label Oct 20, 2017
gibfahn
gibfahn approved these changes Oct 20, 2017
View reviewed changes
Copy link
Member

@gibfahn gibfahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with suggestions.

CONTRIBUTING.md Outdated
@@ -242,6 +242,10 @@ who you are:
$ git config --global user.name "J. Random User"
$ git config --global user.email "j.random.user@example.com"
```
Please make sure this local email is also added to your
[GitHub email list](https://github.com/settings/emails) so that your commits
will be properly associated with your account and you will be timely promoted
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe remove timely, it seems a bit out of place here.

I think timely is actually an adjective, not an adverb (English - nonsense as usual).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

CONTRIBUTING.md Outdated
Please make sure this local email is also added to your
[GitHub email list](https://github.com/settings/emails) so that your commits
will be properly associated with your account and you will be timely promoted
to contributors once your first commit is landed.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe to contributors -> to Contributor (it's a title I think).

Copy link
Contributor Author

@vsemozhetbyt vsemozhetbyt Oct 20, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And done.

@gireeshpunathil
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/10880/

@vsemozhetbyt
Copy link
Contributor Author

2 CI fails seem unrelated.

@gireeshpunathil
Copy link
Member

early-landing.

gireeshpunathil pushed a commit that referenced this pull request Oct 21, 2017
@vsemozhetbyt @gireeshpunathil
meta: add note about email sync to CONTRIBUTING.md
6d4c685 
PR-URL: #16340
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

Refs: #16339 (comment)
@gireeshpunathil
Copy link
Member

Landed in 6d4c685

@vsemozhetbyt vsemozhetbyt deleted the meta-sync-emails branch October 21, 2017 10:59
@vsemozhetbyt vsemozhetbyt mentioned this pull request Oct 21, 2017
Closed
2 tasks
MylesBorins pushed a commit that referenced this pull request Oct 23, 2017
@vsemozhetbyt @MylesBorins
meta: add note about email sync to CONTRIBUTING.md
fd54d8a 
PR-URL: #16340
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

Refs: #16339 (comment)
@vsemozhetbyt vsemozhetbyt mentioned this pull request Oct 23, 2017
Closed
2 tasks
addaleax pushed a commit to ayojs/ayo that referenced this pull request Oct 26, 2017
@vsemozhetbyt @addaleax
meta: add note about email sync to CONTRIBUTING.md
542b277 
PR-URL: nodejs/node#16340
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

Refs: nodejs/node#16339 (comment)
MylesBorins pushed a commit that referenced this pull request Nov 16, 2017
@vsemozhetbyt @MylesBorins
meta: add note about email sync to CONTRIBUTING.md
f838b46 
PR-URL: #16340
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

Refs: #16339 (comment)
@MylesBorins MylesBorins mentioned this pull request Nov 21, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Nov 21, 2017
@vsemozhetbyt @MylesBorins
meta: add note about email sync to CONTRIBUTING.md
72d5af5 
PR-URL: #16340
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

Refs: #16339 (comment)
MylesBorins pushed a commit that referenced this pull request Nov 28, 2017
@vsemozhetbyt @MylesBorins
meta: add note about email sync to CONTRIBUTING.md
b0ac76d 
PR-URL: #16340
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

Refs: #16339 (comment)
addaleax pushed a commit to ayojs/ayo that referenced this pull request Dec 7, 2017
@vsemozhetbyt @addaleax
meta: add note about email sync to CONTRIBUTING.md
7d29d4a 
PR-URL: nodejs/node#16340
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

Refs: nodejs/node#16339 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gibfahn gibfahn gibfahn approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@hiroppy hiroppy hiroppy approved these changes

@tniessen tniessen tniessen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

@Fishrock123 Fishrock123 Fishrock123 approved these changes

@jasnell jasnell jasnell approved these changes

@apapirovski apapirovski apapirovski approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.