Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fixtures module replaced fixturesDir #16262

Closed
wants to merge 1 commit into from
Closed

test: fixtures module replaced fixturesDir #16262

wants to merge 1 commit into from

Conversation

tpurcell
Copy link
Contributor

second attempt taking into account comments made by jasnell

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@tpurcell
test: fixtures module replaced fixturesDir
89d17ca 
second attempt taking into account comments made by jasnell
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 17, 2017
@mscdex mscdex added the https Issues or PRs related to the https subsystem. label Oct 17, 2017
gireeshpunathil
gireeshpunathil approved these changes Oct 18, 2017
View reviewed changes
Copy link
Member

@gireeshpunathil gireeshpunathil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Which was the PR attempted earlier? It is almost always possible to accommodate changes in the same PR itself. Now that we are here, let us progress on this.

@gireeshpunathil
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/10803/

@joyeecheung
Copy link
Member

@gireeshpunathil I guess that's #15936 ?

@joyeecheung joyeecheung mentioned this pull request Oct 18, 2017
Closed
2 tasks
@jasnell
Copy link
Member

jasnell commented Oct 18, 2017

This had lots of weird failures on Linux that all should be unrelated, but just in case, trying again: https://ci.nodejs.org/job/node-test-commit-linux/13307/

@tniessen tniessen self-assigned this Oct 19, 2017
@tniessen
Copy link
Member

Landed in 023b95b, thank you for your contribution! 🎉

@tniessen tniessen closed this Oct 20, 2017
tniessen pushed a commit that referenced this pull request Oct 20, 2017
@tpurcell @tniessen
test: replace fixturesDir with fixtures module
023b95b 
PR-URL: #16262
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
MylesBorins pushed a commit that referenced this pull request Oct 23, 2017
@tpurcell @MylesBorins
test: replace fixturesDir with fixtures module
f9321bb 
PR-URL: #16262
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
addaleax pushed a commit to ayojs/ayo that referenced this pull request Oct 26, 2017
@tpurcell @addaleax
test: replace fixturesDir with fixtures module
ecf846c 
PR-URL: nodejs/node#16262
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
MylesBorins pushed a commit that referenced this pull request Nov 16, 2017
@tpurcell @MylesBorins
test: replace fixturesDir with fixtures module
4a476a5 
PR-URL: #16262
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@MylesBorins MylesBorins mentioned this pull request Nov 21, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Nov 21, 2017
@tpurcell @MylesBorins
test: replace fixturesDir with fixtures module
9527ac9 
PR-URL: #16262
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
MylesBorins pushed a commit that referenced this pull request Nov 28, 2017
@tpurcell @MylesBorins
test: replace fixturesDir with fixtures module
34dfce7 
PR-URL: #16262
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
addaleax pushed a commit to ayojs/ayo that referenced this pull request Dec 7, 2017
@tpurcell @addaleax
test: replace fixturesDir with fixtures module
c2f214f 
PR-URL: nodejs/node#16262
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@benjamingr benjamingr benjamingr approved these changes

@cjihrig cjihrig cjihrig approved these changes

@tniessen tniessen tniessen approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@trivikr trivikr trivikr approved these changes

Assignees

@tniessen tniessen

Labels
https Issues or PRs related to the https subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.