Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: replaced common.fixturesDir usage with common.fixtures module #15947

Closed
wants to merge 2 commits into from
Closed

test: replaced common.fixturesDir usage with common.fixtures module #15947

wants to merge 2 commits into from

Conversation

andyband7
Copy link
Contributor

@andyband7 andyband7 commented Oct 6, 2017 •
edited by tniessen
Loading

Removes the usage of common.fixturesDir and replaces with common.fixtures module

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 6, 2017
@mscdex mscdex added the util Issues and PRs related to the built-in util module. label Oct 6, 2017
@Trott Trott added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Oct 6, 2017
BridgeAR
BridgeAR reviewed Oct 7, 2017
View reviewed changes
test/parallel/test-internal-util-decorate-error-stack.js Outdated
@@ -32,7 +33,7 @@ function checkStack(stack) {
}
let err;
const badSyntaxPath =
path.join(common.fixturesDir, 'syntax', 'bad_syntax')
path.join(fixtures.fixturesDir, 'syntax', 'bad_syntax')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should actually use the fixtures.path function.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For instance,

const badSyntaxPath = fixtures.path('syntax', 'bad_syntax');

@BridgeAR
Copy link
Member

Ping @andyband7

@andyband7
Copy link
Contributor Author

Thanks for the reminder @BridgeAR . Ive committed an updated test, is this how you meant it?

@gireeshpunathil
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/10848/

mhdawson
mhdawson approved these changes Oct 19, 2017
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson
Copy link
Member

AIX issue was not related to this PR.

@mhdawson
Copy link
Member

Windows failures was a not related to this PR. CI run looks good.

@mhdawson
Copy link
Member

@BridgeAR if the change matches what you had in mind I think this is ready to land.

joyeecheung
joyeecheung approved these changes Oct 19, 2017
View reviewed changes
test/parallel/test-internal-util-decorate-error-stack.js
@@ -32,7 +32,7 @@ function checkStack(stack) {
}
let err;
const badSyntaxPath =
path.join(common.fixturesDir, 'syntax', 'bad_syntax')
fixtures.path('syntax', 'bad_syntax')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: this line can be merged with the line above now. This can be handled during landing

@joyeecheung
Copy link
Member

Landed in 76abf0f, thanks!

joyeecheung pushed a commit that referenced this pull request Oct 19, 2017
@andyband7 @joyeecheung
test: replace fixturesDir with fixtures module
76abf0f 
PR-URL: #15947
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 23, 2017
@andyband7 @MylesBorins
test: replace fixturesDir with fixtures module
87804a6 
PR-URL: #15947
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
addaleax pushed a commit to ayojs/ayo that referenced this pull request Oct 26, 2017
@andyband7 @addaleax
test: replace fixturesDir with fixtures module
73851d0 
PR-URL: nodejs/node#15947
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 16, 2017
@andyband7 @MylesBorins
test: replace fixturesDir with fixtures module
45b443c 
PR-URL: #15947
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Nov 21, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Nov 21, 2017
@andyband7 @MylesBorins
test: replace fixturesDir with fixtures module
0296d8b 
PR-URL: #15947
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 28, 2017
@andyband7 @MylesBorins
test: replace fixturesDir with fixtures module
0a88e1b 
PR-URL: #15947
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
addaleax pushed a commit to ayojs/ayo that referenced this pull request Dec 7, 2017
@andyband7 @addaleax
test: replace fixturesDir with fixtures module
690f376 
PR-URL: nodejs/node#15947
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell left review comments

@joyeecheung joyeecheung joyeecheung approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@mhdawson mhdawson mhdawson approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests. util Issues and PRs related to the built-in util module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@andyband7 @BridgeAR @gireeshpunathil @mhdawson @joyeecheung @jasnell @mscdex @MylesBorins @Trott @nodejs-github-bot