Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: replaced common.fixturesDir usage with common.fixtures module #15947

Closed
wants to merge 2 commits into from
Closed

test: replaced common.fixturesDir usage with common.fixtures module #15947

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1275cba
test: replaced common.fixturesDir usage with common.fixtures module
andyband7 Oct 6, 2017
f93a60f
test: replace path.join with fixtures.path
andyband7 Oct 19, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions test/parallel/test-internal-util-decorate-error-stack.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
// Flags: --expose_internals
'use strict';
const common = require('../common');
require('../common');
const fixtures = require('../common/fixtures');
const assert = require('assert');
const internalUtil = require('internal/util');
const binding = process.binding('util');
Expand Down Expand Up @@ -32,7 +33,7 @@ function checkStack(stack) {
}
let err;
const badSyntaxPath =
path.join(common.fixturesDir, 'syntax', 'bad_syntax')
path.join(fixtures.fixturesDir, 'syntax', 'bad_syntax')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should actually use the fixtures.path function.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For instance,

const badSyntaxPath = fixtures.path('syntax', 'bad_syntax');

.replace(/\\/g, '\\\\');

try {
Expand Down