fix: sdk module resolution issues #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Francisco Javier Ribo Labrador <elribonazo@gmail.com>
elribonazo
force-pushed
the
feature/fix-integration-imports
branch
from
842a2b4 to
b1b5c1d
Compare
|
milosh86
approved these changes
Sep 16, 2024
|
@milosh86 in the next 2 weeks i'll schedule something with u and Curtis in order to better understand why this is happening and its root cause. The whole point is that in reality nodejs module resolution is an async process that is known thing in JS, this means that at inmport level, the package can be still undefined. Then, in my opinion, this is something that cucumber-js, in combination with our SDK is affecting but other scenarios, like using the SDK directly work, also, our tests work without this issue. I think what causes trouble is cucumber-js |
hyperledger-bot
added a commit
that referenced
this pull request
Oct 4, 2024
# [6.1.0](v6.0.1...v6.1.0) (2024-10-04) ### Bug Fixes * bitstring improvement and test coverage ([#270](#270)) ([dce65b5](dce65b5)) * e2e cucumber import ([#291](#291)) ([e569d79](e569d79)) * external build update for new generated code ([#264](#264)) ([460102a](460102a)) * main branchname in semantic release config ([#279](#279)) ([a6a72ff](a6a72ff)) * make mediator updateable in the nextjs demo ([#262](#262)) ([99df3c0](99df3c0)) * next generation building tools and testing framework ([#258](#258)) ([54ead35](54ead35)) * nextjs demo safeBody ([#263](#263)) ([0d09ea7](0d09ea7)) * noble-ciphers dependency ([#284](#284)) ([fabcc2c](fabcc2c)) * package dependencies found by mixmix ([#273](#273)) ([#275](#275)) ([82a50d3](82a50d3)) * rollup is not a optionalDependency, and is not included in our m… ([#269](#269)) ([9ea9d42](9ea9d42)) * sdk module resolution issues ([#290](#290)) ([f53d728](f53d728)) * update code-owners ([#281](#281)) ([b8409af](b8409af)) ### Features * Connectionless Offer ([#293](#293)) ([97e05e7](97e05e7)) * Connectionless presentation ([#272](#272)) ([d43ec60](d43ec60)) * decoupling JWT from Pollux and adding KID header to JWTs ([#271](#271)) ([8a1ed3f](8a1ed3f)) * errors introducing error codes and refactoring Apollo errors ([#265](#265)) ([f99c565](f99c565)) * integrating error reporting protocol ([#289](#289)) ([02430db](02430db)) * OIDC Agent ([#278](#278)) ([295e14f](295e14f)) * separate DIDCommAgent and adding Tasks ([#277](#277)) ([3a8fd66](3a8fd66))
elribonazo
added a commit
that referenced
this pull request
Oct 4, 2024
Signed-off-by: Francisco Javier Ribo Labrador <elribonazo@gmail.com>
hyperledger-bot
added a commit
that referenced
this pull request
Oct 4, 2024
# [6.2.0](v6.1.1...v6.2.0) (2024-10-04) ### Bug Fixes * e2e cucumber import ([#291](#291)) ([e569d79](e569d79)) * next generation building tools and testing framework ([#258](#258)) ([54ead35](54ead35)) * sdk module resolution issues ([#290](#290)) ([f53d728](f53d728)) ### Features * Connectionless Offer ([#293](#293)) ([97e05e7](97e05e7)) * integrating error reporting protocol ([#289](#289)) ([02430db](02430db)) * OIDC Agent ([#278](#278)) ([295e14f](295e14f)) * separate DIDCommAgent and adding Tasks ([#277](#277)) ([3a8fd66](3a8fd66))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
fix e2e tests and module resolution issue with the new sdk
Checklist: