Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: noble-ciphers dependency #284

Merged
merged 1 commit into from
Sep 3, 2024
Merged

fix: noble-ciphers dependency #284

merged 1 commit into from
Sep 3, 2024

Conversation

curtis-h
Copy link
Contributor

@curtis-h curtis-h commented Sep 3, 2024

Description:

Noble Ciphers dependency now needs explicit setting

Checklist:

  • My PR follows the contribution guidelines of this project
  • My PR is free of third-party dependencies that don't comply with the Allowlist
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked the PR title to follow the conventional commit specification

Signed-off-by: Curtish <ch@curtish.me>
Copy link

github-actions bot commented Sep 3, 2024

Lines Statements Branches Functions
Coverage: 75%
75.9% (2839/3740) 65.64% (1391/2119) 80.75% (730/904)

JUnit

Tests Skipped Failures Errors Time
527 6 💤 0 ❌ 0 🔥 56.267s ⏱️

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10687658221

Details

  • 1 of 2 (50.0%) changed or added relevant lines in 1 file are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.07%) to 72.134%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/domain/utils/randomBytes.ts 1 2 50.0%
Files with Coverage Reduction New Missed Lines %
src/domain/utils/DER.ts 3 35.14%
Totals Coverage Status
Change from base Build 10685863937: -0.07%
Covered Lines: 2774
Relevant Lines: 3655

💛 - Coveralls

@amagyar-iohk amagyar-iohk merged commit fabcc2c into main Sep 3, 2024
5 checks passed
@amagyar-iohk amagyar-iohk deleted the fix/noble-ciphers branch September 3, 2024 18:13
hyperledger-bot added a commit that referenced this pull request Sep 5, 2024
# [6.1.0-rc.1](v6.0.1...v6.1.0-rc.1) (2024-09-05)

### Bug Fixes

* bitstring improvement and test coverage ([#270](#270)) ([dce65b5](dce65b5))
* external build update for new generated code ([#264](#264)) ([460102a](460102a))
* main branchname in semantic release config ([#279](#279)) ([a6a72ff](a6a72ff))
* make mediator updateable in the nextjs demo ([#262](#262)) ([99df3c0](99df3c0))
* nextjs demo safeBody ([#263](#263)) ([0d09ea7](0d09ea7))
* noble-ciphers dependency ([#284](#284)) ([fabcc2c](fabcc2c))
* package dependencies found by mixmix ([#273](#273)) ([#275](#275)) ([82a50d3](82a50d3))
* rollup is not a optionalDependency, and is not included in our m… ([#269](#269)) ([9ea9d42](9ea9d42))

### Features

* Connectionless presentation ([#272](#272)) ([d43ec60](d43ec60))
* decoupling JWT from Pollux and adding KID header to JWTs ([#271](#271)) ([8a1ed3f](8a1ed3f))
* errors introducing error codes and refactoring Apollo errors ([#265](#265)) ([f99c565](f99c565))
hyperledger-bot added a commit that referenced this pull request Sep 11, 2024
# [6.1.0](v6.0.1...v6.1.0) (2024-09-11)

### Bug Fixes

* bitstring improvement and test coverage ([#270](#270)) ([dce65b5](dce65b5))
* external build update for new generated code ([#264](#264)) ([460102a](460102a))
* main branchname in semantic release config ([#279](#279)) ([a6a72ff](a6a72ff))
* make mediator updateable in the nextjs demo ([#262](#262)) ([99df3c0](99df3c0))
* nextjs demo safeBody ([#263](#263)) ([0d09ea7](0d09ea7))
* noble-ciphers dependency ([#284](#284)) ([fabcc2c](fabcc2c))
* package dependencies found by mixmix ([#273](#273)) ([#275](#275)) ([82a50d3](82a50d3))
* rollup is not a optionalDependency, and is not included in our m… ([#269](#269)) ([9ea9d42](9ea9d42))
* update code-owners ([#281](#281)) ([b8409af](b8409af))

### Features

* Connectionless presentation ([#272](#272)) ([d43ec60](d43ec60))
* decoupling JWT from Pollux and adding KID header to JWTs ([#271](#271)) ([8a1ed3f](8a1ed3f))
* errors introducing error codes and refactoring Apollo errors ([#265](#265)) ([f99c565](f99c565))
hyperledger-bot added a commit that referenced this pull request Sep 12, 2024
# [6.1.0](v6.0.1...v6.1.0) (2024-09-12)

### Bug Fixes

* bitstring improvement and test coverage ([#270](#270)) ([dce65b5](dce65b5))
* external build update for new generated code ([#264](#264)) ([460102a](460102a))
* main branchname in semantic release config ([#279](#279)) ([a6a72ff](a6a72ff))
* make mediator updateable in the nextjs demo ([#262](#262)) ([99df3c0](99df3c0))
* nextjs demo safeBody ([#263](#263)) ([0d09ea7](0d09ea7))
* noble-ciphers dependency ([#284](#284)) ([fabcc2c](fabcc2c))
* package dependencies found by mixmix ([#273](#273)) ([#275](#275)) ([82a50d3](82a50d3))
* rollup is not a optionalDependency, and is not included in our m… ([#269](#269)) ([9ea9d42](9ea9d42))
* update code-owners ([#281](#281)) ([b8409af](b8409af))

### Features

* Connectionless presentation ([#272](#272)) ([d43ec60](d43ec60))
* decoupling JWT from Pollux and adding KID header to JWTs ([#271](#271)) ([8a1ed3f](8a1ed3f))
* errors introducing error codes and refactoring Apollo errors ([#265](#265)) ([f99c565](f99c565))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants