Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm install fails #273

Closed
mixmix opened this issue Aug 25, 2024 · 4 comments · Fixed by #275
Closed

npm install fails #273

mixmix opened this issue Aug 25, 2024 · 4 comments · Fixed by #275
Assignees

Comments

@mixmix
Copy link
Contributor

mixmix commented Aug 25, 2024

Is this a regression?

Yes

Description

Doesn't install happily on a fresh install with npm. Seems to be some typedoc version problems in your repo

Please provide the exception or error you saw

➜  ATALA cd test
➜  test npm init -y
Wrote to /home/fakename/projects/ATALA/test/package.json:

{
  "name": "test",
  "version": "1.0.0",
  "description": "",
  "main": "index.js",
  "scripts": {
    "test": "echo \"Error: no test specified\" && exit 1"
  },
  "keywords": [],
  "author": "",
  "license": "ISC"
}


➜  test npm i @hyperledger/identus-edge-agent-sdk
npm WARN deprecated inflight@1.0.6: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.
npm WARN deprecated rimraf@2.7.1: Rimraf versions prior to v4 are no longer supported
npm WARN deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported
npm WARN deprecated text-encoding@0.7.0: no longer maintained
npm ERR! code 1
npm ERR! path /home/fakename/projects/ATALA/test/node_modules/@hyperledger/identus-edge-agent-sdk
npm ERR! command failed
npm ERR! command sh -c sh preinstall.sh
npm ERR! running preinstall in /home/fakename/projects/ATALA/test/node_modules/@hyperledger/identus-edge-agent-sdk
npm ERR! npm ERR! code ERESOLVE
npm ERR! npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! npm ERR!
npm ERR! npm ERR! While resolving: @hyperledger/identus-edge-agent-sdk@6.0.0
npm ERR! npm ERR! Found: typedoc@0.25.13
npm ERR! npm ERR! node_modules/typedoc
npm ERR! npm ERR!   dev typedoc@"^0.25.6" from the root project
npm ERR! npm ERR!
npm ERR! npm ERR! Could not resolve dependency:
npm ERR! npm ERR! peer typedoc@">=0.26 <2.0" from typedoc-plugin-external-module-map@2.1.0
npm ERR! npm ERR! node_modules/typedoc-plugin-external-module-map
npm ERR! npm ERR!   dev typedoc-plugin-external-module-map@"^2.0.1" from the root project
npm ERR! npm ERR!
npm ERR! npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! npm ERR! this command with --force or --legacy-peer-deps
npm ERR! npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

Please provide the environment you discovered this bug in

➜  node -v
v20.10.0
➜  npm -v
10.2.3

Anything else?

😢

@hyperledger hyperledger deleted a comment Aug 26, 2024
@elribonazo
Copy link
Contributor

I'm taking a look this week at that, for now @mixmix just install the updated typedoc. I'll update you on this tomorrow

@elribonazo elribonazo self-assigned this Aug 27, 2024
@elribonazo elribonazo linked a pull request Aug 27, 2024 that will close this issue
6 tasks
elribonazo added a commit that referenced this issue Aug 27, 2024
Signed-off-by: Francisco Javier Ribo Labrador <elribonazo@gmail.com>
elribonazo added a commit that referenced this issue Aug 27, 2024
Signed-off-by: Francisco Javier Ribo Labrador <elribonazo@gmail.com>
@elribonazo
Copy link
Contributor

Sorry @mixmix the issue was closed automatically when the PR merged, we have now updated the package json to stick to the correct version of typedoc.

All should be fine now, feel free to re-open if u think its still affecting in any way

amagyar-iohk pushed a commit that referenced this issue Aug 27, 2024
Signed-off-by: Francisco Javier Ribo Labrador <elribonazo@gmail.com>
@chereseeriepa
Copy link

@elribonazo do you have an idea on when a version with this fix will be released?

hyperledger-bot added a commit that referenced this issue Sep 5, 2024
# [6.1.0-rc.1](v6.0.1...v6.1.0-rc.1) (2024-09-05)

### Bug Fixes

* bitstring improvement and test coverage ([#270](#270)) ([dce65b5](dce65b5))
* external build update for new generated code ([#264](#264)) ([460102a](460102a))
* main branchname in semantic release config ([#279](#279)) ([a6a72ff](a6a72ff))
* make mediator updateable in the nextjs demo ([#262](#262)) ([99df3c0](99df3c0))
* nextjs demo safeBody ([#263](#263)) ([0d09ea7](0d09ea7))
* noble-ciphers dependency ([#284](#284)) ([fabcc2c](fabcc2c))
* package dependencies found by mixmix ([#273](#273)) ([#275](#275)) ([82a50d3](82a50d3))
* rollup is not a optionalDependency, and is not included in our m… ([#269](#269)) ([9ea9d42](9ea9d42))

### Features

* Connectionless presentation ([#272](#272)) ([d43ec60](d43ec60))
* decoupling JWT from Pollux and adding KID header to JWTs ([#271](#271)) ([8a1ed3f](8a1ed3f))
* errors introducing error codes and refactoring Apollo errors ([#265](#265)) ([f99c565](f99c565))
hyperledger-bot added a commit that referenced this issue Sep 11, 2024
# [6.1.0](v6.0.1...v6.1.0) (2024-09-11)

### Bug Fixes

* bitstring improvement and test coverage ([#270](#270)) ([dce65b5](dce65b5))
* external build update for new generated code ([#264](#264)) ([460102a](460102a))
* main branchname in semantic release config ([#279](#279)) ([a6a72ff](a6a72ff))
* make mediator updateable in the nextjs demo ([#262](#262)) ([99df3c0](99df3c0))
* nextjs demo safeBody ([#263](#263)) ([0d09ea7](0d09ea7))
* noble-ciphers dependency ([#284](#284)) ([fabcc2c](fabcc2c))
* package dependencies found by mixmix ([#273](#273)) ([#275](#275)) ([82a50d3](82a50d3))
* rollup is not a optionalDependency, and is not included in our m… ([#269](#269)) ([9ea9d42](9ea9d42))
* update code-owners ([#281](#281)) ([b8409af](b8409af))

### Features

* Connectionless presentation ([#272](#272)) ([d43ec60](d43ec60))
* decoupling JWT from Pollux and adding KID header to JWTs ([#271](#271)) ([8a1ed3f](8a1ed3f))
* errors introducing error codes and refactoring Apollo errors ([#265](#265)) ([f99c565](f99c565))
hyperledger-bot added a commit that referenced this issue Sep 12, 2024
# [6.1.0](v6.0.1...v6.1.0) (2024-09-12)

### Bug Fixes

* bitstring improvement and test coverage ([#270](#270)) ([dce65b5](dce65b5))
* external build update for new generated code ([#264](#264)) ([460102a](460102a))
* main branchname in semantic release config ([#279](#279)) ([a6a72ff](a6a72ff))
* make mediator updateable in the nextjs demo ([#262](#262)) ([99df3c0](99df3c0))
* nextjs demo safeBody ([#263](#263)) ([0d09ea7](0d09ea7))
* noble-ciphers dependency ([#284](#284)) ([fabcc2c](fabcc2c))
* package dependencies found by mixmix ([#273](#273)) ([#275](#275)) ([82a50d3](82a50d3))
* rollup is not a optionalDependency, and is not included in our m… ([#269](#269)) ([9ea9d42](9ea9d42))
* update code-owners ([#281](#281)) ([b8409af](b8409af))

### Features

* Connectionless presentation ([#272](#272)) ([d43ec60](d43ec60))
* decoupling JWT from Pollux and adding KID header to JWTs ([#271](#271)) ([8a1ed3f](8a1ed3f))
* errors introducing error codes and refactoring Apollo errors ([#265](#265)) ([f99c565](f99c565))
@mixmix
Copy link
Contributor Author

mixmix commented Sep 17, 2024

Cool, this is published in 6.1.0 now 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants
@mixmix @elribonazo @chereseeriepa and others