Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: integrating error reporting protocol #289

Merged
merged 2 commits into from
Sep 17, 2024
Merged

fix: integrating error reporting protocol #289

merged 2 commits into from
Sep 17, 2024

Conversation

elribonazo
Copy link
Contributor

Description:

Adding the error reporting protocol as requested in ATL-5914, added one minor test and demo app which I manually tested.

Checklist:

  • My PR follows the contribution guidelines of this project
  • My PR is free of third-party dependencies that don't comply with the Allowlist
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked the PR title to follow the conventional commit specification

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 16, 2024 •
edited
Loading

Lines Statements Branches Functions
Coverage: 77%
 78.11% (3430/4391) 67.2% (1508/2244) 81.73% (828/1013)

milosh86
milosh86 approved these changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@milosh86 milosh86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, let's just merge it with commit message with feat: instead of fix: as this seems like a new feature.

@elribonazo
fix: manage and store error reporting protocol and test
4127f1b 
Signed-off-by: Francisco Javier Ribo Labrador <elribonazo@gmail.com>
@elribonazo
fix: add demo content
675c99a 
Signed-off-by: Francisco Javier Ribo Labrador <elribonazo@gmail.com>
@elribonazo elribonazo merged commit 02430db into main Sep 17, 2024
6 checks passed
@elribonazo elribonazo deleted the feature/ATL-5914 branch September 17, 2024 08:42
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10899471234

Details

  • 7 of 22 (31.82%) changed or added relevant lines in 4 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.3%) to 74.24%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/edge-agent/helpers/ProtocolHelpers.ts 1 5 20.0%
src/edge-agent/protocols/other/ProblemReport.ts 0 11 0.0%
Files with Coverage Reduction New Missed Lines %
src/edge-agent/mediator/BasicMediatorHandler.ts 1 24.42%
Totals Coverage Status
Change from base Build 10899449273: -0.3%
Covered Lines: 3325
Relevant Lines: 4266
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milosh86 milosh86 milosh86 approved these changes

@amagyar-iohk amagyar-iohk Awaiting requested review from amagyar-iohk amagyar-iohk is a code owner

@curtis-h curtis-h Awaiting requested review from curtis-h curtis-h is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elribonazo @coveralls @milosh86