Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: e2e cucumber import #291

Merged
merged 2 commits into from
Sep 17, 2024
Merged

fix: e2e cucumber import #291

merged 2 commits into from
Sep 17, 2024

Conversation

elribonazo
Copy link
Contributor

@elribonazo elribonazo commented Sep 17, 2024 •
edited
Loading

Description:

fix e2e tests not working due to some incompatibilities. We've proven the SDK works in the needed environments but for some reason we were unable to run e2e until this fixes have been implemented

Checklist:

  • My PR follows the contribution guidelines of this project
  • My PR is free of third-party dependencies that don't comply with the Allowlist
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked the PR title to follow the conventional commit specification

@elribonazo elribonazo requested review from amagyar-iohk, curtis-h and milosh86 and removed request for amagyar-iohk September 17, 2024 11:41
@elribonazo elribonazo changed the title Fix/e2e cucumber import fix:e2e cucumber import Sep 17, 2024
@elribonazo elribonazo changed the title fix:e2e cucumber import fix: e2e cucumber import Sep 17, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 17, 2024 •
edited
Loading

Lines Statements Branches Functions
Coverage: 77%
 78.15% (3428/4386) 67.21% (1507/2242) 81.73% (828/1013)

@coveralls
Copy link

coveralls commented Sep 17, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10902597003

Details

  • 3 of 4 (75.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 74.273%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/mercury/didcomm/Wrapper.ts 0 1 0.0%
Totals Coverage Status
Change from base Build 10902579776: 0.03%
Covered Lines: 3323
Relevant Lines: 4261
💛 - Coveralls

milosh86
milosh86 approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@milosh86 milosh86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

integration-tests/e2e-tests/src/abilities/WalletSdk.ts Show resolved Hide resolved
@elribonazo
fix: simplify wasm loading on sdk
efd34fa 
Signed-off-by: Francisco Javier Ribo Labrador <elribonazo@gmail.com>
@elribonazo
fix: incompatibility with cucumberjs loading imported package
12fee72 
Signed-off-by: Francisco Javier Ribo Labrador <elribonazo@gmail.com>
@elribonazo elribonazo merged commit e569d79 into main Sep 17, 2024
6 checks passed
@elribonazo elribonazo deleted the fix/e2e-cucumber-import branch September 17, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milosh86 milosh86 milosh86 approved these changes

@curtis-h curtis-h Awaiting requested review from curtis-h

@amagyar-iohk amagyar-iohk Awaiting requested review from amagyar-iohk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elribonazo @coveralls @milosh86