Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update all samples to use async/await #2869

Closed
54 of 55 tasks
JustinBeckwith opened this issue Oct 4, 2018 · 3 comments · May be fixed by praveenqlogic/nodejs-bigtable#1
Closed
54 of 55 tasks

Update all samples to use async/await #2869

JustinBeckwith opened this issue Oct 4, 2018 · 3 comments · May be fixed by praveenqlogic/nodejs-bigtable#1
Assignees
@JustinBeckwith
Labels
help wanted We'd love to have community involvement on this issue. type: process A process-related concern. May include testing, release, or the like.

Comments

@JustinBeckwith
Copy link
Contributor

JustinBeckwith commented Oct 4, 2018 •
edited by praveenqlogic
Loading

Most of our samples are using promises for async programming, which is great. Now that Node 8 is the latest LTS, and 10 is about to go out - we should start converting all the samples to async/await. Lets use this as a high level tracking bug.

@sduskis this is something that we should have our new friends help with :)

To call out the specific work:

  • All samples should use async or await instead of promises or callbacks
  • We can remove all of the catch clauses that just print the output to console.error (a throw will do that anyway)
@JustinBeckwith
Copy link
Contributor Author

cc @ofrobots

@JustinBeckwith JustinBeckwith added the type: process A process-related concern. May include testing, release, or the like. label Oct 4, 2018
@JustinBeckwith JustinBeckwith added the help wanted We'd love to have community involvement on this issue. label Oct 11, 2018
@vijay-qlogic vijay-qlogic mentioned this issue Oct 23, 2018
Merged
3 tasks
@muraliQlogic muraliQlogic mentioned this issue Oct 23, 2018
Merged
3 tasks
@vijay-qlogic vijay-qlogic mentioned this issue Oct 24, 2018
Merged
3 tasks
@praveenqlogic praveenqlogic mentioned this issue Oct 25, 2018
Closed
3 tasks
@vijay-qlogic vijay-qlogic mentioned this issue Oct 25, 2018
Merged
3 tasks
@praveenqlogic praveenqlogic mentioned this issue Oct 25, 2018
Merged
3 tasks
This was referenced Oct 30, 2018
Merged
Merged
This was referenced Nov 4, 2018
Merged
Merged
Merged
@sduskis
Copy link
Contributor

sduskis commented Nov 12, 2018

@JustinBeckwith did you mean to close this? There's still plenty of work to be done.

@vijay-qlogic
Copy link
Contributor

@JustinBeckwith For nodejs-iot No tests specified to run. Any changes required here?

This was referenced Nov 19, 2018
Merged
Merged
Merged
Merged
Merged
Closed
Merged
This was referenced Nov 20, 2018
Merged
Merged
Merged
Merged
Merged
Merged
Open
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Nov 21, 2018
Merged
Merged
@praveenqlogic praveenqlogic mentioned this issue Nov 23, 2018
Merged
3 tasks
@vijay-qlogic vijay-qlogic mentioned this issue Nov 30, 2018
Merged
3 tasks
@JustinBeckwith JustinBeckwith self-assigned this Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JustinBeckwith JustinBeckwith

Labels
help wanted We'd love to have community involvement on this issue. type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs(samples): updated samples code to use async await praveenqlogic/nodejs-bigtable
3 participants
@sduskis @JustinBeckwith @vijay-qlogic