Samples to use async/await #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #305 +/- ##
========================================
Coverage ? 96.4%
========================================
Files ? 13
Lines ? 1057
Branches ? 143
========================================
Hits ? 1019
Misses ? 32
Partials ? 6Continue to review full report at Codecov.
|
JustinBeckwith
suggested changes
Oct 30, 2018
samples/subscriptions.js
Outdated
| // setInterval() gets run every 10s. | ||
| const interval = setInterval(function() { | ||
| // Every 10s, we do a check on the processing states of the messages. | ||
| Object.keys(messages).forEach(async ackId => { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
samples/subscriptions.js
Outdated
| // Pub/Sub messages are unordered, so here we manually order messages by | ||
| // their "counterId" attribute which was set when they were published. | ||
| const outstandingIds = Object.keys(outstandingMessages).map(counterId => | ||
| parseInt(counterId, 10) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
👋 This has a lot of merge conflicts now :/ Apologies! |
JustinBeckwith
approved these changes
Nov 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works towards googleapis/google-cloud-node#2865 and googleapis/google-cloud-node#2869 (it's a good idea to open an issue first for discussion)