Skip to content
This repository has been archived by the owner on Oct 17, 2023. It is now read-only.

docs(samples): updated samples code to use async await #154

Merged

Conversation

praveenqlogic
Copy link
Contributor

Fixes googleapis/google-cloud-node#2869 (it's a good idea to open an issue first for discussion)
Fixes https://github.com/googleapis/nodejs-translate.

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 25, 2018
samples/automl/automlTranslationDataset.js Outdated Show resolved Hide resolved
samples/automl/automlTranslationDataset.js Outdated Show resolved Hide resolved
samples/automl/automlTranslationDataset.js Show resolved Hide resolved
samples/automl/automlTranslationModel.js Outdated Show resolved Hide resolved
@JustinBeckwith JustinBeckwith changed the title docs(Translate samples): updated samples code to use async await docs(samples): updated samples code to use async await Oct 25, 2018
@JustinBeckwith JustinBeckwith added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 26, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 26, 2018
@codecov
Copy link

codecov bot commented Oct 28, 2018

Codecov Report

Merging #154 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #154   +/-   ##
=======================================
  Coverage   97.67%   97.67%           
=======================================
  Files           2        2           
  Lines         344      344           
  Branches       21       21           
=======================================
  Hits          336      336           
  Misses          2        2           
  Partials        6        6

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85a0cd6...c0bf645. Read the comment docs.

@JustinBeckwith JustinBeckwith added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 28, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 28, 2018
@JustinBeckwith JustinBeckwith merged commit 02e955d into googleapis:master Oct 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants