-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(samples): updated samples code to use async await #385
docs(samples): updated samples code to use async await #385
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great start! Already looking a lot cleaner.
samples/batch.js
Outdated
console.error('ERROR:', err); | ||
}); | ||
try { | ||
const data = await transaction.createQueryPartitions(query); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
samples/batch.js
Outdated
const data = await transaction.createQueryPartitions(query); | ||
const partitions = data[0]; | ||
console.log(`Successfully created ${partitions.length} query partitions.`); | ||
} catch (err) { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
samples/system-test/spanner.test.js
Outdated
t.regex(output, /Successfully deleted 5 records/); | ||
} | ||
); | ||
// // update_data |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Codecov Report
@@ Coverage Diff @@
## master #385 +/- ##
=========================================
Coverage ? 99.54%
=========================================
Files ? 12
Lines ? 1323
Branches ? 0
=========================================
Hits ? 1317
Misses ? 6
Partials ? 0 Continue to review full report at Codecov.
|
Looks like the system tests are still failin |
Yes, working to fix those failure
…On Tue, Oct 23, 2018 at 7:27 AM Justin Beckwith ***@***.***> wrote:
Looks like the system tests are still failin
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#385 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AiYqSN68nVPP-xrKF9Duwe44BG68ZA9eks5unneVgaJpZM4XzSYr>
.
|
71ff75d
to
bf32c4c
Compare
@vijay-qlogic I sent you an invite to the googleapis org. If you accept that, sample and system tests will run automatically on these PRs :) |
@JustinBeckwith Yes, I accepted that invitation Thanks!, also enabled 2-factor authentication as well |
2ced6de
to
ea404f2
Compare
@@ -122,7 +119,7 @@ function readWriteTransaction(instanceId, databaseId, projectId) { | |||
const transferAmount = 200000; | |||
const minimumAmountToTransfer = 300000; | |||
|
|||
database.runTransaction((err, transaction) => { | |||
database.runTransaction(async (err, transaction) => { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Fixes googleapis/google-cloud-node#2869 (it's a good idea to open an issue first for discussion)