Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

docs(samples): updated samples code to use async await #214

Merged
merged 4 commits into from
Oct 26, 2018
Merged

docs(samples): updated samples code to use async await #214

merged 4 commits into from
Oct 26, 2018

Conversation

vijay-qlogic
Copy link
Contributor

Fixes googleapis/google-cloud-node/issues/2869 (it's a good idea to open an issue first for discussion)

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 25, 2018
@vijay-qlogic vijay-qlogic changed the title updated samples code to use async await docs(samples): updated samples code to use async await Oct 25, 2018
@JustinBeckwith JustinBeckwith added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 25, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 25, 2018
JustinBeckwith
JustinBeckwith reviewed Oct 25, 2018
View reviewed changes
samples/recognize.js Outdated
});
} catch (err) {

This comment was marked as spam.

Sign in to view

samples/recognize.js Outdated
.join('\n');
console.log(`Transcription: ${transcription}`);
} catch (err) {
console.error('ERROR:', err);

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

samples/recognize.js Outdated
.catch(err => {
console.error('ERROR:', err);
});
const [{results}] = await client.recognize(request);

This comment was marked as spam.

Sign in to view

samples/betaFeatures.js Outdated
});
const [response] = await client.recognize(request);
const transcription = response.results
.map(

This comment was marked as spam.

Sign in to view

@codecov
Copy link

codecov bot commented Oct 26, 2018 •
edited
Loading

Codecov Report

Merging #214 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #214   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines          35     35           
=====================================
  Hits           35     35

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af7c0c0...1e46881. Read the comment docs.

@JustinBeckwith JustinBeckwith added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 26, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 26, 2018
@JustinBeckwith
Copy link
Contributor

This is looking great! But... we have a few sample test failures. As soon as those are addressed, this is good to go.

@JustinBeckwith JustinBeckwith merged commit 97b3e0c into googleapis:master Oct 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JustinBeckwith JustinBeckwith JustinBeckwith approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vijay-qlogic @JustinBeckwith @googlebot @kokoro-team