Skip to content
This repository has been archived by the owner on Jul 20, 2023. It is now read-only.

docs(samples): updated samples code to use async await #139

Merged
merged 3 commits into from
Nov 23, 2018

Conversation

praveenqlogic
Copy link
Contributor

Fixes googleapis/google-cloud-node#2869 (it's a good idea to open an issue first for discussion)
Fixes https://github.com/googleapis/nodejs-resource

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 20, 2018
@JustinBeckwith JustinBeckwith added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 20, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 20, 2018
@praveenqlogic
Copy link
Contributor Author

@JustinBeckwith : Hi Justin, there is error "Resource is not a constructor" due to which tests is getting failed, let me know any suggestions on it.

image

@JustinBeckwith JustinBeckwith merged commit 79d7250 into googleapis:master Nov 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants