Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(samples): Samples to use async/await #262

Merged
merged 3 commits into from
Nov 27, 2018
Merged

refactor(samples): Samples to use async/await #262

merged 3 commits into from
Nov 27, 2018

Conversation

muraliQlogic
Copy link
Contributor

Fixes google-cloud-node/issues/2869 (it's a good idea to open an issue first for discussion)

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 23, 2018
JustinBeckwith
JustinBeckwith suggested changes Nov 24, 2018
View reviewed changes
Copy link
Contributor

@JustinBeckwith JustinBeckwith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original code here was weird.

samples/concepts.js Outdated Show resolved Hide resolved
samples/concepts.js Outdated Show resolved Hide resolved
samples/concepts.js Outdated Show resolved Hide resolved
samples/concepts.js Outdated Show resolved Hide resolved
samples/concepts.js Show resolved Hide resolved
samples/concepts.js Outdated Show resolved Hide resolved
samples/quickstart.js Outdated Show resolved Hide resolved
samples/tasks.js Show resolved Hide resolved
samples/tasks.js Outdated Show resolved Hide resolved
samples/tasks.js Outdated Show resolved Hide resolved
@JustinBeckwith JustinBeckwith changed the title Samples to use async/await refactor(samples): Samples to use async/await Nov 27, 2018
@JustinBeckwith JustinBeckwith merged commit 30e8346 into googleapis:master Nov 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustinBeckwith JustinBeckwith JustinBeckwith approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@muraliQlogic @JustinBeckwith @googlebot