[Maps] Change TOC pop-up wording to reflect filter change, not search bar change #105163
Conversation
kindsun
added
[Deprecated-Use Team:Presentation]Team:Geo
|
Pinging @elastic/kibana-gis (Team:Geo) |
There was a problem hiding this comment.
I'm neither here nor there. I think the idea of "search bar" was that it captures the idea that anything from the query (KQL/Lucene-queries) or filter bar (kibana filter pills) is being applied. How these got populated isn't really defined (manual entry, from tooltip, from other visualization on dashboard, ...)
Maybe then actually change it to: 'Results narrowed by global filters or searchbar?'
tbh I don't know, but I get the confusion. 🤷
I'd say: merge it if there's a second yay on it :)
| @@ -116,7 +116,7 @@ export class TOCEntryButton extends Component<Props, State> { | |||
| footnotes.push({ | |||
| icon: <EuiIcon color="subdued" type="filter" size="s" />, | |||
| message: i18n.translate('xpack.maps.layer.isUsingSearchMsg', { | |||
| defaultMessage: 'Results narrowed by search bar', | |||
| defaultMessage: 'Results narrowed by filter', | |||
There was a problem hiding this comment.
@gchaps Is there a word or phrase used to address the search bar in Kibana? Looking at https://www.elastic.co/guide/en/kibana/7.13/kibana-concepts-analysts.html#kibana-concepts-searching-your-data there does not appear to be one.
There was a problem hiding this comment.
In docs, we use search query or query for a request for information about data. Could the tooltip be this:
Results narrowed by your query and filters.
OR
Results narrowed by your search query and filters.
There was a problem hiding this comment.
I updated the wording to "Results narrowed by query and filters", just removed "your" to generally match other wording in the Maps app
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
… bar change (elastic#105163) * Change pop-up wording * Review feedback. Update wording
…-png-pdf-report-type * 'master' of github.com:elastic/kibana: (292 commits) bring back KQL autocomplete in timeline + fix last updated (elastic#105380) [Maps] Change TOC pop-up wording to reflect filter change, not search bar change (elastic#105163) Updating urls to upstream elastic repo (elastic#105250) [Maps] Move new vector layer wizard card down (elastic#104797) Exclude registering the cases feature if not enabled (elastic#105292) [Uptime] Alerts - Monitor status alert - check monitor status by monitor.timespan (elastic#104541) updated UI copy (elastic#105184) Log a warning when documents of unknown types are detected during migration (elastic#105213) [Logs UI] Register log threshold rule as lifecycle rule (elastic#104341) [Ingest pipelines] add network direction processor (elastic#103436) [Console] Autocomplete definitions (manual backport) (elastic#105086) [Security Solution] User can make Exceptions for Memory protection alerts (elastic#102196) [Lens] Formula: add validation for multiple field/metrics (elastic#104092) Removing async from file upload and data visualizer plugins start lifecycle (elastic#105197) Fix error when validating the form with non blocking validations (elastic#103629) [ML] Fix "View by" swim lane with applied filter and sorting by score (elastic#105217) Update dependency @elastic/charts to v32 (elastic#104625) [CTI] shortens large numbers on Dashboard Link Panel (elastic#105269) [Security Solution][Endpoint][Host Isolation] Fixes bug to remove excess host metadata status toasts on non user initiated errors (elastic#105331) [Cases] Fix pushing alerts count on every push to external service (elastic#105030) ... # Conflicts: # x-pack/plugins/reporting/common/types.ts
Filters aren't always applied from the search bar, sometimes they're applied from tooltips. Updated the wording from:
'Results narrowed by search bar'->'Results narrowed by filter'