[Ingest pipelines] add network direction processor #103436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@elasticmachine merge upstream |
sabarasaba
commented
Jun 30, 2021
...cation/components/pipeline_editor/components/processor_form/processors/network_direction.tsx
Show resolved
Hide resolved
sabarasaba
added
Feature:Ingest Node Pipelines
|
Pinging @elastic/kibana-stack-management (Team:Stack Management) |
|
@elasticmachine merge upstream |
sebelga
requested changes
Jul 1, 2021
There was a problem hiding this comment.
Great work @sabarasaba ! Tested locally and works as expected 👍
As I looked at how you had to work around getting the isCustom state initial value I decided that the best was that the form would expose the handler to read the defaultValue of a field. This way we don't need to rely on useEffect to modify the value of the state.
I also had another look at the problem of eagerly merging any prop coming "in" that are not returned by the form. I found it more complex what you had in place (having to manually set the field value then reset the field and use a <UseMultiField />) instead of manually listing the fields that we don't want to be merged back in.
I created a PR with my suggestion sabarasaba#1, feel free to comment there and merge it if you are happy. 👍
...cation/components/pipeline_editor/components/processor_form/processors/network_direction.tsx
Show resolved
Hide resolved
...cation/components/pipeline_editor/components/processor_form/processors/network_direction.tsx
Outdated
Show resolved
Hide resolved
...cation/components/pipeline_editor/components/processor_form/processors/network_direction.tsx
Outdated
Show resolved
Hide resolved
…ode_review Add network direction processor code review
|
@elasticmachine merge upstream |
cnasikas
approved these changes
Jul 5, 2021
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: cc @sabarasaba |
sabarasaba
added a commit
to sabarasaba/kibana
that referenced
this pull request
Jul 13, 2021
* initial form setup * custom solution with usemultifields * wip: sort of working now * fix bootstraping of initial state * fix field validation * add tests * fix linter errors * Fix i18 namespace * Fix linter problems and remove unused whitelisting * Fix copy for description * lil prettier fix * add docs and tweak copy * small tweaks * [Form lib] expose handler to access field defaultValue * Refactor <NetworkDirection /> * fix up import orders * Fix test mocks * Move up mocks a bit Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Sébastien Loix <sabee77@gmail.com>
sabarasaba
added a commit
that referenced
this pull request
Jul 13, 2021
* initial form setup * custom solution with usemultifields * wip: sort of working now * fix bootstraping of initial state * fix field validation * add tests * fix linter errors * Fix i18 namespace * Fix linter problems and remove unused whitelisting * Fix copy for description * lil prettier fix * add docs and tweak copy * small tweaks * [Form lib] expose handler to access field defaultValue * Refactor <NetworkDirection /> * fix up import orders * Fix test mocks * Move up mocks a bit Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Sébastien Loix <sabee77@gmail.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Sébastien Loix <sabee77@gmail.com>
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Jul 13, 2021
…-png-pdf-report-type * 'master' of github.com:elastic/kibana: (292 commits) bring back KQL autocomplete in timeline + fix last updated (elastic#105380) [Maps] Change TOC pop-up wording to reflect filter change, not search bar change (elastic#105163) Updating urls to upstream elastic repo (elastic#105250) [Maps] Move new vector layer wizard card down (elastic#104797) Exclude registering the cases feature if not enabled (elastic#105292) [Uptime] Alerts - Monitor status alert - check monitor status by monitor.timespan (elastic#104541) updated UI copy (elastic#105184) Log a warning when documents of unknown types are detected during migration (elastic#105213) [Logs UI] Register log threshold rule as lifecycle rule (elastic#104341) [Ingest pipelines] add network direction processor (elastic#103436) [Console] Autocomplete definitions (manual backport) (elastic#105086) [Security Solution] User can make Exceptions for Memory protection alerts (elastic#102196) [Lens] Formula: add validation for multiple field/metrics (elastic#104092) Removing async from file upload and data visualizer plugins start lifecycle (elastic#105197) Fix error when validating the form with non blocking validations (elastic#103629) [ML] Fix "View by" swim lane with applied filter and sorting by score (elastic#105217) Update dependency @elastic/charts to v32 (elastic#104625) [CTI] shortens large numbers on Dashboard Link Panel (elastic#105269) [Security Solution][Endpoint][Host Isolation] Fixes bug to remove excess host metadata status toasts on non user initiated errors (elastic#105331) [Cases] Fix pushing alerts count on every push to external service (elastic#105030) ... # Conflicts: # x-pack/plugins/reporting/common/types.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #90709
Release Note
The Ingest Node Pipelines UI added support to configure a network direction processor. This processor calculates the network direction given a source IP address, destination IP address, and a list of internal networks.
Default description
New processor fields