Fix error when validating the form with non blocking validations #103629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
machadoum
added
the
bug
machadoum
commented
Jun 29, 2021
src/plugins/es_ui_shared/static/forms/hook_form_lib/hooks/use_field.test.tsx
Show resolved
Hide resolved
machadoum
force-pushed
the
stack-management-formlib-issue-102338
branch
from
5a7e071
to
42bda1d
Compare
sebelga
requested changes
Jun 29, 2021
There was a problem hiding this comment.
Thanks for adding the fix for this @machadoum ! Looks great, I made a few comments in the code cheers 👍
src/plugins/es_ui_shared/static/forms/hook_form_lib/hooks/use_field.test.tsx
Show resolved
Hide resolved
src/plugins/es_ui_shared/static/forms/hook_form_lib/hooks/use_field.test.tsx
Outdated
Show resolved
Hide resolved
src/plugins/es_ui_shared/static/forms/hook_form_lib/hooks/use_field.test.tsx
Show resolved
Hide resolved
src/plugins/es_ui_shared/static/forms/hook_form_lib/hooks/use_field.test.tsx
Outdated
Show resolved
Hide resolved
machadoum
force-pushed
the
stack-management-formlib-issue-102338
branch
from
42bda1d
to
9cf3d17
Compare
machadoum
added
release_note:skip
machadoum
commented
Jul 6, 2021
src/plugins/es_ui_shared/static/forms/components/fields/combobox_field.tsx
Outdated
Show resolved
Hide resolved
machadoum
force-pushed
the
stack-management-formlib-issue-102338
branch
2 times, most recently
from
6a5d15c
to
e8fb07d
Compare
machadoum
force-pushed
the
stack-management-formlib-issue-102338
branch
from
e8fb07d
to
b165157
Compare
sebelga
approved these changes
Jul 12, 2021
There was a problem hiding this comment.
Thanks again for the contribution @machadoum ! I think now it works as expected 👍
|
@elasticmachine merge upstream |
sebelga
added
the
Team:Kibana Management
|
Pinging @elastic/kibana-stack-management (Team:Stack Management) |
💚 Build SucceededMetrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: cc @machadoum |
2 tasks
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Jul 13, 2021
…-png-pdf-report-type * 'master' of github.com:elastic/kibana: (292 commits) bring back KQL autocomplete in timeline + fix last updated (elastic#105380) [Maps] Change TOC pop-up wording to reflect filter change, not search bar change (elastic#105163) Updating urls to upstream elastic repo (elastic#105250) [Maps] Move new vector layer wizard card down (elastic#104797) Exclude registering the cases feature if not enabled (elastic#105292) [Uptime] Alerts - Monitor status alert - check monitor status by monitor.timespan (elastic#104541) updated UI copy (elastic#105184) Log a warning when documents of unknown types are detected during migration (elastic#105213) [Logs UI] Register log threshold rule as lifecycle rule (elastic#104341) [Ingest pipelines] add network direction processor (elastic#103436) [Console] Autocomplete definitions (manual backport) (elastic#105086) [Security Solution] User can make Exceptions for Memory protection alerts (elastic#102196) [Lens] Formula: add validation for multiple field/metrics (elastic#104092) Removing async from file upload and data visualizer plugins start lifecycle (elastic#105197) Fix error when validating the form with non blocking validations (elastic#103629) [ML] Fix "View by" swim lane with applied filter and sorting by score (elastic#105217) Update dependency @elastic/charts to v32 (elastic#104625) [CTI] shortens large numbers on Dashboard Link Panel (elastic#105269) [Security Solution][Endpoint][Host Isolation] Fixes bug to remove excess host metadata status toasts on non user initiated errors (elastic#105331) [Cases] Fix pushing alerts count on every push to external service (elastic#105030) ... # Conflicts: # x-pack/plugins/reporting/common/types.ts
machadoum
added a commit
to machadoum/kibana
that referenced
this pull request
Jul 13, 2021
…stic#103629) * Fix error when validating the form with non blocking validations issue: elastic#102338 * Add a flag to only validate blocking validation when validating the form * Refactor bypass validation Co-authored-by: Sébastien Loix <sabee77@gmail.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
machadoum
added a commit
that referenced
this pull request
Jul 13, 2021
…3629) (#105478) * Fix error when validating the form with non blocking validations issue: #102338 * Add a flag to only validate blocking validation when validating the form * Refactor bypass validation Co-authored-by: Sébastien Loix <sabee77@gmail.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Sébastien Loix <sabee77@gmail.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
|
@sebelga Should this be backported to 7.14? |
|
I don't think so this was not critical and an enhancement in a security form. @machadoum correct me if I'm wrong. |
|
I agree with @sebelga. It is a small improvement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: #102338
Summary
Change
validationTypedefault value ofvalidate()function onuse_field.tsfile. This change makes sure that ArrayItem validations are ignored when theform.validate()is called.I added tests for the form validation and also for field validation with different values for
isBlocking.Checklist